Skip to content

Personalized RelationshipTemplates#270

Merged
Magnus-Kuhn merged 30 commits intomainfrom
personalized-templates
Oct 11, 2024
Merged

Personalized RelationshipTemplates#270
Magnus-Kuhn merged 30 commits intomainfrom
personalized-templates

Conversation

@Magnus-Kuhn
Copy link
Copy Markdown
Contributor

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 13, 2024

@Magnus-Kuhn Magnus-Kuhn added the enhancement New feature or request label Sep 13, 2024
@Magnus-Kuhn Magnus-Kuhn marked this pull request as ready for review September 13, 2024 10:51
@Magnus-Kuhn
Copy link
Copy Markdown
Contributor Author

This PR has no changes to the reference, so there's no runtime validation when loading a template with the truncated reference.

@Magnus-Kuhn Magnus-Kuhn changed the title Relationship Templates can be personalized to be accessed only by a specific identity RelationshipTemplates can be personalized to be accessed only by a specific identity Sep 13, 2024
@jkoenig134
Copy link
Copy Markdown
Contributor

This PR has no changes to the reference, so there's no runtime validation when loading a template with the truncated reference.

we should introduce the change to the reference in an earlier PR and not merge this or #249 before. I'd suggest to make this a draft again until we figured out what we do with truncated references.

@Magnus-Kuhn Magnus-Kuhn marked this pull request as draft September 13, 2024 11:10
@jkoenig134 jkoenig134 changed the title RelationshipTemplates can be personalized to be accessed only by a specific identity Personalized RelationshipTemplates Sep 18, 2024
@jkoenig134 jkoenig134 added the wip Work in Progress (blocks mergify from auto update the branch) label Sep 19, 2024
@Magnus-Kuhn Magnus-Kuhn removed the wip Work in Progress (blocks mergify from auto update the branch) label Oct 2, 2024
@Magnus-Kuhn Magnus-Kuhn marked this pull request as ready for review October 2, 2024 08:58
Comment thread packages/runtime/src/useCases/common/Schemas.ts
Comment thread packages/runtime/test/dataViews/RelationshipTemplateDVO.test.ts Outdated
Comment thread packages/transport/test/modules/tokens/TokenController.test.ts
@Magnus-Kuhn Magnus-Kuhn requested a review from stnmtz October 10, 2024 08:13
Copy link
Copy Markdown
Contributor

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkoenig134
Copy link
Copy Markdown
Contributor

@stnmtz you are blocking this PR 'case you have changes requested. Any addition to comments you had?

@Magnus-Kuhn Magnus-Kuhn enabled auto-merge (squash) October 10, 2024 13:03
@Magnus-Kuhn Magnus-Kuhn merged commit 2da60aa into main Oct 11, 2024
@Magnus-Kuhn Magnus-Kuhn deleted the personalized-templates branch October 11, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants