Personalized RelationshipTemplates#270
Merged
Magnus-Kuhn merged 30 commits intomainfrom Oct 11, 2024
Merged
Conversation
Contributor
Author
|
This PR has no changes to the reference, so there's no runtime validation when loading a template with the truncated reference. |
Contributor
we should introduce the change to the reference in an earlier PR and not merge this or #249 before. I'd suggest to make this a draft again until we figured out what we do with truncated references. |
stnmtz
requested changes
Oct 2, 2024
jkoenig134
reviewed
Oct 9, 2024
jkoenig134
reviewed
Oct 9, 2024
Contributor
|
@stnmtz you are blocking this PR 'case you have changes requested. Any addition to comments you had? |
stnmtz
approved these changes
Oct 11, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readiness checklist