Skip to content

Process personalized and password protected objects in the StringProcessor#299

Merged
jkoenig134 merged 54 commits intomainfrom
process-personalized-and-password-protected-objects-in-apps
Dec 2, 2024
Merged

Process personalized and password protected objects in the StringProcessor#299
jkoenig134 merged 54 commits intomainfrom
process-personalized-and-password-protected-objects-in-apps

Conversation

@jkoenig134
Copy link
Copy Markdown
Contributor

@jkoenig134 jkoenig134 commented Oct 17, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Description

Brings support for personalized and password protected objects to the app-runtime.

Adds support for features from #249 #270 #295.

I tried to mock the UIBridge with ts-mockito, but this completely blew up - so I wrote a custom mocking implementation including custom matcher support.

@jkoenig134 jkoenig134 added enhancement New feature or request wip Work in Progress (blocks mergify from auto update the branch) labels Oct 17, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 17, 2024

@jkoenig134 jkoenig134 removed the wip Work in Progress (blocks mergify from auto update the branch) label Nov 26, 2024
Comment thread packages/app-runtime/src/AppRuntime.ts Outdated
Comment thread packages/app-runtime/src/AppStringProcessor.ts Outdated
Comment thread packages/app-runtime/src/AppStringProcessor.ts Outdated
Comment thread packages/app-runtime/test/customMatchers.ts Outdated
Comment thread packages/app-runtime/test/lib/MockEventBus.ts Outdated
Comment thread packages/app-runtime/test/runtime/AppStringProcessor.test.ts Outdated
Comment thread packages/app-runtime/test/runtime/AppStringProcessor.test.ts
Comment thread packages/app-runtime/test/runtime/AppStringProcessor.test.ts Outdated
stnmtz
stnmtz previously approved these changes Dec 2, 2024
Magnus-Kuhn
Magnus-Kuhn previously approved these changes Dec 2, 2024
Comment thread packages/app-runtime/test/lib/MockUIBridge.matchers.ts Outdated
Comment thread packages/transport/src/core/Reference.ts Outdated
Comment thread packages/app-runtime/test/runtime/AppStringProcessor.test.ts
Comment thread packages/app-runtime/test/runtime/AppStringProcessor.test.ts
Comment thread packages/app-runtime/test/lib/MockUIBridge.matchers.ts Outdated
@jkoenig134 jkoenig134 enabled auto-merge (squash) December 2, 2024 14:14
@jkoenig134 jkoenig134 merged commit 95dc437 into main Dec 2, 2024
@jkoenig134 jkoenig134 deleted the process-personalized-and-password-protected-objects-in-apps branch December 2, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants