Skip to content

Add settings/ and accounts/ to .gitignore - #267

Merged
deiu merged 2 commits into
masterfrom
dz_add_settings_gitignore
Mar 7, 2016
Merged

Add settings/ and accounts/ to .gitignore#267
deiu merged 2 commits into
masterfrom
dz_add_settings_gitignore

Conversation

@dmitrizagidulin

Copy link
Copy Markdown
Contributor

No description provided.

@deiu

deiu commented Mar 2, 2016

Copy link
Copy Markdown

Do we actually need this? You should not run ldnode (or set the root) in the git repository.

@dmitrizagidulin
dmitrizagidulin force-pushed the dz_add_settings_gitignore branch from 6ec3de0 to b667f68 Compare March 2, 2016 20:01
@dmitrizagidulin

Copy link
Copy Markdown
Contributor Author

@deiu - what do you mean? Developers will often run ldnode in the git repo (including myself). This is to prevent them accidentally committing the created dirs.

@deiu

deiu commented Mar 2, 2016

Copy link
Copy Markdown

In fact, what we need is to prevent running ldnode without specifying a root directory.

@nicola

nicola commented Mar 5, 2016

Copy link
Copy Markdown
Contributor

@deiu why? it is incredibly handy to just type "ldnode" and everything works!

@deiu

deiu commented Mar 5, 2016

Copy link
Copy Markdown

Sure, it works, but you end up with a lot of garbage in your dev directory. In fact, I didn't mean running ldnode after installing from npm but running ldnode from the repo.

@dmitrizagidulin

Copy link
Copy Markdown
Contributor Author

Why don't we just merge this PR and let developers decide where they want to run it from :)

@csarven

csarven commented Mar 5, 2016

Copy link
Copy Markdown
Member

There is room for both:

git cloners are going to do whatever is obvious and convenient ("hey, is this going to work right out of the box? Do I really have to read/configure.. "). Adding some .gitignores is a simple-enough measure so that it does not pose any conflicts for their next pull. Granted, the long-term solution is to use the config properly, but why force that right from the start.

IMO, removing all frictions to get something working out of the box should be a priority. Personally, I want to see what works with the defaults - I can then later decide what to do with the configs once I'm better familiar.

Having said all that, the out of the box is more fitting for the npm approach than it is to git repo. So, whatever... :)

@nicola

nicola commented Mar 5, 2016

Copy link
Copy Markdown
Contributor

+1 for me

deiu pushed a commit that referenced this pull request Mar 7, 2016
Add settings/ and accounts/ to .gitignore
@deiu
deiu merged commit 385c802 into master Mar 7, 2016
@dmitrizagidulin
dmitrizagidulin deleted the dz_add_settings_gitignore branch March 7, 2016 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants