Fix redirect - #273
Merged
Merged
Conversation
|
|
||
| // Redirect to container with / if missing | ||
| if (container && path.lastIndexOf('/') !== path.length - 1) { | ||
| debug(contentType) |
Contributor
There was a problem hiding this comment.
can you add some details to this log?
Author
|
Hold on, removing debugs. [Update] done! |
Contributor
|
Sorry I just tried out the new feature from github that lets you merge the master into the PR so that the PR is up to date |
| // Just return, since resource exists | ||
| if (!includeBody) { | ||
| return callback(null, stats) | ||
| return callback(null, stats, contentType, stats.isDirectory()) |
Contributor
There was a problem hiding this comment.
if we pass stats there is no need to pass stats.isDirectory()
Contributor
There was a problem hiding this comment.
also when is the contentType used?
Author
There was a problem hiding this comment.
The problem occurs later on, since otherwise container will be undefined. This is the relevant line: https://github.com/linkeddata/ldnode/blob/fix-redirect/lib/handlers/get.js#L64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redirect
/footo/foo/if missing slash and the resource is a container.