-
Notifications
You must be signed in to change notification settings - Fork 307
Fix redirect #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redirect #273
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -383,7 +383,7 @@ LDP.prototype.get = function (host, reqPath, baseUri, includeBody, contentType, | |
|
|
||
| // Just return, since resource exists | ||
| if (!includeBody) { | ||
| return callback(null, stats) | ||
| return callback(null, stats, contentType, stats.isDirectory()) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if we pass stats there is no need to pass
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also when is the
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The problem occurs later on, since otherwise |
||
| } | ||
|
|
||
| // Found a container | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really want to redirect every time? I am not sure I understand why this should always happen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because
/fooand/foo/are not the same thing. For example, this breaks relative URIs you get from dereferencing/foo.