Fix ACL check for internal index.html redirect - #282
Merged
Conversation
| @@ -18,40 +16,27 @@ function handler (req, res, next) { | |||
| if (err) return next() | |||
|
|
|||
| res.locals.path = req.path | |||
Author
|
OK, I've removed that obsolete line. Ready for merge. |
nicola
added a commit
that referenced
this pull request
Mar 14, 2016
Fix ACL check for internal index.html redirect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given a private container
/foo/and a public document/foo/index.html, lnode's ACL system currently checks if/foo/is readable before passing the request to the index handler, therefore blocking access to/foo/index.html.This PR introduces a fix, where the index handler takes precedence over the ACL check for read operations (GET).