Skip to content

Add Accept-Post to Access-Control-Expose-Headers#412

Merged
dmitrizagidulin merged 1 commit into
nodeSolidServer:dz_accept_postfrom
csarven:dz_accept_post
Jul 3, 2016
Merged

Add Accept-Post to Access-Control-Expose-Headers#412
dmitrizagidulin merged 1 commit into
nodeSolidServer:dz_accept_postfrom
csarven:dz_accept_post

Conversation

@csarven

@csarven csarven commented Jul 3, 2016

Copy link
Copy Markdown
Member

Required in order to expose a non-simple header for CORS.

@dmitrizagidulin

Copy link
Copy Markdown
Contributor

I thought about adding that header to Access-Control-Expose-Headers, in my original PR. And then decided against it -- the Access-Control-... header only applies to non-OPTIONS requests. Whereas the Accept-Post header is only returned with OPTIONS. Hence, we don't need it.

@csarven

csarven commented Jul 3, 2016

Copy link
Copy Markdown
Member Author

Consider:

Accept-Post is a MUST in OPTIONS in LDP, but it is not strictly for OPTIONS. It can be present in other methods.

Browsers still throw a Refused to get unsafe header if Accept-Post is not present. There is no harm in adding this as far as I can tell.

@dmitrizagidulin

Copy link
Copy Markdown
Contributor

it's only implemented to return with OPTIONS, tho...

@dmitrizagidulin dmitrizagidulin merged commit 38c6e33 into nodeSolidServer:dz_accept_post Jul 3, 2016
@deiu deiu removed the in progress label Jul 3, 2016
dmitrizagidulin added a commit that referenced this pull request Jul 5, 2016
* Return Accept-Post header on OPTIONS requests to containers

Fixes issue #409.

* Add Accept-Post to Access-Control-Expose-Headers (#412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants