In a directory listing, adds the media type class when we know it #456
Conversation
|
@timbl I fixed the jsStandard formatting errors that were failing the test and pushed to this PR. Now there's some tests failing about container serialization; investigating. |
|
@dmitrizagidulin it is exactly th container list test which I would expect to fail, as that is what has changed. I need to understand the proper way of running the tests .... |
|
@timbl the easiest way to run the tests is to just invoke |
… directory member. Add dct:modified with an RDF date.
dmitrizagidulin
force-pushed
the
contentType
branch
from
783e4ab to
edf1153
Compare
dmitrizagidulin
force-pushed
the
contentType
branch
from
edf1153 to
7533152
Compare
…itrary serialization choice
dmitrizagidulin
left a comment
dmitrizagidulin
left a comment
There was a problem hiding this comment.
Looks good. (Though we should refactor the general structure of the LDP class and container listing, later on.)
| ' o:limit 500000.00 .', 'sampleContainer/magicType.ttl') | ||
|
|
||
| ldp.listContainer(path.join(__dirname, '/resources/sampleContainer/'), 'https://server.tld', '', 'text/turtle', function (err, data) { | ||
| ldp.listContainer(path.join(__dirname, '/resources/sampleContainer/'), 'https://server.tld/resources/sampleContainer/', 'https://server.tld', '', 'text/turtle', function (err, data) { |
There was a problem hiding this comment.
Isn't this the equivalent of just passing "/resources/sampleContainer/" ?
|
I just figured out you're using Jasmine in ldp.js :) https://jasmine.github.io/2.0/introduction.html |
* Remove unused n3 dependency * Refactor listContainer() to use absolute file urls * In a directory listing, add the media type class when we know it of a directory member. Add dct:modified with an RDF date. * Fix Standard formatting errors * Fix rename variable * Provide base uri to list container serialize * Fix listContainer contains triples * WIP fix * Pass through the baseUri to serialize * Fix listContainer tests * Add the new test from previous work which had been failing due to arbitrary serialization choice * Fix test formatting * Bump rdflib dep version
4 participants
In a directory listing, adds the media type class when we know it for a directory member. Add sdct:modified with an RDF date, which IMHO should deprocate the mtime returned as a unixinteger. (The RDF way is when know the data type and RDF has it, you use it. Note the code is actually shorter, internally node uses s Date() object)
Addresses Issue #446