Skip to content

Update transfer repo instructions to be nodejs/.github-aware#682

Merged
aduh95 merged 2 commits intomainfrom
update-transfer-repo-instructions
Mar 22, 2023
Merged

Update transfer repo instructions to be nodejs/.github-aware#682
aduh95 merged 2 commits intomainfrom
update-transfer-repo-instructions

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented May 1, 2022

Refs: nodejs/.github#2
Refs: nodejs/.github#3

@nodejs/tsc

the project.
- `README.md`

Ideally, it would not have the following documents to inherit them from
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was some discussion that when you clone a repo that inherits like this you don't get a copy of the files and that might be a concern.

I don't remember if/where that concern was discussed/addressed but it's probably good to document that it's understood that there will not be copies in case of a clone (unless that has changed or I've got that wrong) and its a choice that we have made on purpose.

@nodejs/tsc any concerns with the code of conduct or contributing files not showing up in a clone?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct that you do not get a copy of the Code of Conduct checked into the repo.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, the .github pattern is pretty prevalent and I don't think people expect the files to be always present.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb I can understand that, but that is independant from the decision within the project that it's ok not to have a copy in the checked out repo. That is what I thought would be good add to this documentation. That they won't be there AND that the project decided that was ok.

Comment thread transfer-repo-into-the-org.md
@aduh95 aduh95 requested a review from mhdawson March 22, 2023 18:47
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 merged commit 9c673f4 into main Mar 22, 2023
@aduh95 aduh95 deleted the update-transfer-repo-instructions branch March 22, 2023 19:00
XProudfootX

This comment was marked as spam.

@Trott

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants