src: support loading symbols from shared libraries#154
Merged
joyeecheung merged 2 commits intonodejs:masterfrom Dec 21, 2017
Merged
src: support loading symbols from shared libraries#154joyeecheung merged 2 commits intonodejs:masterfrom
joyeecheung merged 2 commits intonodejs:masterfrom
Conversation
6779931 to
1a5c2e5
Compare
Member
Author
27d559c to
4bcc500
Compare
Member
Author
|
Ping @bnoordhuis @cjihrig @indutny Can you review this? Thanks! |
4bcc500 to
6eee8fd
Compare
Member
Author
|
Rebased. Ping @bnoordhuis @cjihrig @indutny please review, thanks! |
PR-URL: nodejs#154 Fixes: nodejs#153 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#154 Fixes: nodejs#153 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
6eee8fd to
82cdeaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables support for loading symbols from shared libraries, e.g. d8 with libv8 and friends.
Below is the debug session in d8 with the simplified d8-scenario.js, I didn't include things like thin strings because some metadata changes needed are floated in node's 6.2 branch.
Tested on macos and ubuntu 16.04 with the d8 built from v8 6.2 branch head.
Inspecting the function source does not work at the moment, but the related symbols loaded are the same as node v9.2, and it seems to be related to #138(It works, butv8 i -s <function>doesn't, even thoughv8 print <function>andv8 source list <function>works, see #153 (comment)) so I think that can be fixed in another PR.Fixes: #153
See d8 debug session (v8 version 6.2.414.46, 6.2 branch head)