Closed
Conversation
Drieger
force-pushed
the
start_colorization
branch
2 times, most recently
from
cd43b14 to
d739920
Compare
Drieger
force-pushed
the
start_colorization
branch
3 times, most recently
from
e070f2a to
55aeb93
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Drieger
force-pushed
the
start_colorization
branch
from
55aeb93 to
85df42e
Compare
Contributor
Author
|
@mmarchini I think all requests were addressed on last commit |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
@joyeecheung PTAL. I guess it's ok to introduce rang as a dependency, right? |
Drieger
force-pushed
the
start_colorization
branch
from
24af1df to
59c8f22
Compare
Contributor
Author
|
@mmarchini Just addressed last two comments. |
Member
|
@mmarchini Won't be able to take a look at this until the weekend, but having a in-tree dependency in the public domain doesn't seem to a problem from me. |
Contributor
|
@joyeecheung no worries! There's no rush in landing this, so if you want you can take a look when you have the time :) @Drieger can you please rebase this? There are some conflicts after #227 landed. |
To make visualization easier, objects types, properties and addresses will be colorized. Using `rang` library color pallete, the current definition is: * cyan for addresses * magenta for objects being inspected * yellow for types * bold yellow for objects properties Fixes: nodejs#179 Colorize findrefs output
Allow users to select if color output should be on or off. Default is auto, which verifies if current output is a tty and has color support. Colorize detailed output
Drieger
force-pushed
the
start_colorization
branch
from
7237407 to
83eba13
Compare
Contributor
Author
|
@mmarchini Conflicts solved |
mmarchini
pushed a commit
that referenced
this pull request
Oct 5, 2018
To make visualization easier, objects types, properties and addresses will be colorized. Using `rang` library color pallete, the current definition is: * cyan for addresses * magenta for objects being inspected * yellow for types * bold yellow for objects properties Fixes: #179 Colorize findrefs output PR-URL: #225 Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Contributor
|
Landed in 7b09c15, thank you! |
hyj1991
pushed a commit
to aliyun-node/llnode
that referenced
this pull request
Oct 11, 2018
To make visualization easier, objects types, properties and addresses will be colorized. Using `rang` library color pallete, the current definition is: * cyan for addresses * magenta for objects being inspected * yellow for types * bold yellow for objects properties Fixes: nodejs#179 Colorize findrefs output PR-URL: nodejs#225 Reviewed-By: Matheus Marchini <mat@mmarchini.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add colors to llnode output and introduce a settings class, which allow users to select if it should
alwaysuse colorization,neveruse colorization or if it shouldautoselect based on current output and color support. By default optionauto, to change this option one should use the following commandAlmost all output of
findjsinstancesare already colorized, I'm still working on other commands. Image below shows an output example.