feat: port test_object core to CTS - #73
Open
bavulapati wants to merge 1 commit into
Open
Conversation
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the stable core of
test/js-native-api/test_object: property get/set/has/delete, property-name modes, wrap/unwrap across prototype chains, type tags, and seal/freeze.Upstream asserts V8's exact error text for the seal/freeze violations (
Cannot add property w, object is not extensible). Test files are modules and therefore strict, so those violations still throw; this port assertsTypeErrorinstead of engine-specific message text.node_api_create_object_with_propertiesis left out; it is experimental and lands as its own addon in a follow-up.test_nullandtest_exceptionsfollow as separate PRs, after which PORTING.md moves off Partial.