feat: port test_object test_null to CTS - #79
Open
bavulapati wants to merge 2 commits into
Open
Conversation
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
test_null.c/test_null.js- NULL-argument handling across the object property, element and descriptor APIs. Compiled into thetest_objectaddon and exported astestNull, matching the existingtest_stringpattern.Two upstream defects surfaced here:
setElement/getElementcallednapi_set_property/napi_get_property, so the element cases were not testing the element APIs. Corrected; expectations are unchanged.utf8nameIsNullandmethodIsNullcases mutate the descriptor but still pass a NULL descriptor list, so they re-testdescriptorListIsNull. Passing a real descriptor instead segfaults, becausenapi_define_propertiesdereferences a descriptor with no name rather than returningnapi_invalid_arg. Worth a separate issue on nodejs/node.Stacked on #73 - review that first.