Skip to content

test-node-output-v8-warning is failing #310

@joyeecheung

Description

@joyeecheung

This was added nodejs/node#24365 - V8 recently deprecated asm.js validation (asm.js as a whole is deprecated too I think) and there doesn't seem to be any other way to reliably trigger v8::Isolate::kMessageWarning now, it seems better to just remove the test.

https://github.com/nodejs/node-v8/actions/runs/26155918444/job/76935124557

=== release test-node-output-v8-warning ===
Path: parallel/test-node-output-v8-warning
Error: --- stdout ---
Test failure: 'v8/v8_warning.js'
Location: test/parallel/test-node-output-v8-warning.mjs:11:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ ''
- '(node:<pid>) V8: <project-root>/test/fixtures/v8/v8_warning.js:13 Invalid asm.js: Invalid return type\n' +
-   '(Use `<node-exe> --trace-warnings ...` to show where the warning was created)\n'

    at assertSnapshot (/Users/runner/work/node-v8/node-v8/node/test/common/assertSnapshot.js:173:12)
    at async Module.spawnAndAssert (/Users/runner/work/node-v8/node-v8/node/test/common/assertSnapshot.js:208:3)
    at async TestContext.<anonymous> (file:///Users/runner/work/node-v8/node-v8/node/test/parallel/test-node-output-v8-warning.mjs:12:7)
    at async Test.run (node:internal/test_runner/test:1373:7)
    at async Promise.all (index 0)
    at async Suite.run (node:internal/test_runner/test:1846:7)
    at async startSubtestAfterBootstrap (node:internal/test_runner/harness:387:3) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: '',
  expected: '(node:<pid>) V8: <project-root>/test/fixtures/v8/v8_warning.js:13 Invalid asm.js: Invalid return type\n' +
    '(Use `<node-exe> --trace-warnings ...` to show where the warning was created)\n',
  operator: 'strictEqual',
  diff: 'simple'
}
Command: out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/runner/work/node-v8/node-v8/node/test/parallel/test-node-output-v8-warning.mjs

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions