Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v17.1.0 release proposal #40758

Merged
merged 117 commits into from
Nov 9, 2021
Merged

v17.1.0 release proposal #40758

merged 117 commits into from
Nov 9, 2021

Commits on Oct 23, 2021

  1. src: register external references in crypto bindings

    PR-URL: #40239
    Refs: #38905
    Refs: #37476
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    a11f9ea View commit details
    Browse the repository at this point in the history
  2. src: register external references in os bindings

    PR-URL: #40239
    Refs: #38905
    Refs: #37476
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    accab38 View commit details
    Browse the repository at this point in the history
  3. meta: consolidate AUTHORS entries for cxreg

    PR-URL: #40490
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Trott authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    e4c7406 View commit details
    Browse the repository at this point in the history
  4. lib: add return value for DC channel.unsubscribe

    PR-URL: #40433
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    simon-id authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    aa61551 View commit details
    Browse the repository at this point in the history
  5. lib: add unsubscribe method to non-active DC channels

    PR-URL: #40433
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    simon-id authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    1ddbae2 View commit details
    Browse the repository at this point in the history
  6. test: fix test description

    The request uses chunked transfer encoding and the HTTP response status
    code is not 400 but 200.
    
    PR-URL: #40486
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    lpinca authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    aefb097 View commit details
    Browse the repository at this point in the history
  7. meta: consolidate AUTHORS entries for dguo

    PR-URL: #40517
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    6a771f8 View commit details
    Browse the repository at this point in the history
  8. meta: add Richard Lau to TSC list in README.md

    Refs: nodejs/TSC#1096
    
    PR-URL: #40523
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    7cee125 View commit details
    Browse the repository at this point in the history
  9. doc: add updating expected assets to release guide

    Add a section to the Major Releases section of the release guide
    to cover updating the list of expected files for the promotion tool.
    
    PR-URL: #40470
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    richardlau authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    5a588ff View commit details
    Browse the repository at this point in the history
  10. src,fs: remove ToLocalChecked() call from fs::AfterMkdirp()

    This merges the `IsEmpty()` call and the `ToLocalChecked()` call into a
    single `ToLocal()` call.
    
    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40386
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    RaisinTen authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    814126c View commit details
    Browse the repository at this point in the history
  11. src,crypto: remove AllocatedBuffer from crypto_cipher.cc

    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40400
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    RaisinTen authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    4433852 View commit details
    Browse the repository at this point in the history
  12. typings: separate internalBinding typings

    PR-URL: #40409
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Mesteery authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    1e9f3cc View commit details
    Browse the repository at this point in the history
  13. src,stream: remove *Check*() calls from non-Initialize() functions

    There is no need to crash the process if any of these checks fail.
    
    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40425
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    RaisinTen authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    d4b45cc View commit details
    Browse the repository at this point in the history
  14. doc: clarify behavior of napi_extended_error_info

    Fix up example and make it more explicit on how
    you need to use napi_extended_error_info in order to
    help people avoid what might be a common mistake that
    we made in node-addon-api.
    
    Refs: nodejs/node-addon-api#1089
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #40458
    Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    mhdawson authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    34e244b View commit details
    Browse the repository at this point in the history
  15. deps,build,tools: fix openssl-is-fips for ninja builds

    Currently using the --openssl-is-fips configuration option in
    combination with --ninja is broken.
    
    This commit fixes two issues, one being an issue with the linker/version
    script path variable. The second is that the locations of built
    artifacts that differ for ninja and make.
    
    ninja:
    $ ./configure --openssl-is-fips --ninja
    $ ninja -C out/Release
    $ ./node --enable-fips -p 'crypto.getFips()'
    1
    
    make:
    $ ./configure --openssl-is-fips
    $ make -j8
    $ ./node --enable-fips -p 'crypto.getFips()'
    1
    
    PR-URL: #40518
    Refs: #40509
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    danbev authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    5df8ce5 View commit details
    Browse the repository at this point in the history
  16. deps: regenerate OpenSSL arch files

    PR-URL: #40518
    Refs: #40509
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    danbev authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    d2839bf View commit details
    Browse the repository at this point in the history
  17. deps: attempt to suppress macro-redefined warning

    PR-URL: #40518
    Refs: #40509
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    danbev authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    2b9fcdf View commit details
    Browse the repository at this point in the history
  18. lib: fix regular expression to detect / and \

    Fixes #40305
    
    PR-URL: #40325
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    fasttime authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    81cd7f3 View commit details
    Browse the repository at this point in the history
  19. meta: move one or more collaborators to emeritus

    PR-URL: #40464
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Yihong Wang <yh.wang@ibm.com>
    nodejs-github-bot authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    bd06e99 View commit details
    Browse the repository at this point in the history
  20. doc: update link in onboarding doc

    PR-URL: #40539
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    ed04827 View commit details
    Browse the repository at this point in the history
  21. deps: add riscv64 config into openssl gypi

    PR-URL: #40473
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    luyahan authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    cdf5c44 View commit details
    Browse the repository at this point in the history
  22. src,crypto: use std::variant in DH params

    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40457
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    RaisinTen authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    ef1ace7 View commit details
    Browse the repository at this point in the history
  23. doc: document considerations for inclusion in core

    Document the things that are considered when making the determination as
    to whether something should or shouldn't be in core. This does not (yet,
    at least) attempt to address *how* to include modules in core. (Should
    it be in the Node.js code base or vendored in from a separate
    repository?) It is limited to *whether* something should be in core or
    not.
    
    Closes: nodejs/TSC#1041
    
    PR-URL: #40338
    Fixes: nodejs/TSC#1041
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    6357ef1 View commit details
    Browse the repository at this point in the history
  24. doc: add VoltrexMaster to collaborators

    Fixes: #40323
    
    PR-URL: #40566
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    VoltrexKeyva authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    89b34ec View commit details
    Browse the repository at this point in the history
  25. meta: consolidate AUTHORS entries for dfabulich

    PR-URL: #40527
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    ba9a6c5 View commit details
    Browse the repository at this point in the history
  26. doc: fix entry for Slack channel in onboarding.md

    PR-URL: #40563
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Trott authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    4993d87 View commit details
    Browse the repository at this point in the history
  27. doc: explain backport labels

    PR-URL: #40520
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Qard authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    0375d95 View commit details
    Browse the repository at this point in the history
  28. doc: add missing entry in globals.md

    Refs: #39759 (comment)
    
    PR-URL: #40531
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    acc22c7 View commit details
    Browse the repository at this point in the history
  29. doc: update for changed --dns-result-order default

    Update documentation to match the changed `--dns-result-order` default
    value in Node.js 17.
    
    Refs: #39987
    
    PR-URL: #40538
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    richardlau authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    404730a View commit details
    Browse the repository at this point in the history
  30. doc: fix fs.symlink code example

    Fixes: #40413
    
    PR-URL: #40414
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    juanarbol authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    fd94621 View commit details
    Browse the repository at this point in the history
  31. doc: use GFM footnotes in BUILDING.md

    PR-URL: #40474
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    9c6a9fd View commit details
    Browse the repository at this point in the history
  32. doc: use GFM footnotes in maintaining-V8.md (#40476)

    PR-URL: #40476
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    556e49c View commit details
    Browse the repository at this point in the history
  33. tools: update license-builder.sh for OpenSSL

    PR-URL: #40540
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    c2265a9 View commit details
    Browse the repository at this point in the history
  34. doc: run license-builder

    PR-URL: #40540
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    6e39e0e View commit details
    Browse the repository at this point in the history
  35. deps: V8: cherry-pick 422dc378a1da

    Original commit message:
    
        [deserialization] Remove unnecessarily limit on buffer size
    
        1. Now there is no serializer/deserializer-specific buffer size limit.
        2. Update AUTHORS
    
        Ref: #40059
    
        Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411
        Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
        Reviewed-by: Clemens Backes <clemensb@chromium.org>
        Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#77084}
    
    Refs: v8/v8@422dc37
    
    PR-URL: #40450
    Fixes: #40059
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    rayw000 authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    8d16f0d View commit details
    Browse the repository at this point in the history
  36. src: throw error instead of assertion

    PR-URL: #40243
    Fixes: #40059
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    rayw000 authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    396342e View commit details
    Browse the repository at this point in the history
  37. doc: describe buffer limit of v8.serialize

    PR-URL: #40243
    Fixes: #40059
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    rayw000 authored and targos committed Oct 23, 2021
    1 Configuration menu
    Copy the full SHA
    305c022 View commit details
    Browse the repository at this point in the history
  38. tty: support more CI services in getColorDepth

    PR-URL: #40385
    Refs: sindresorhus/yoctocolors#5
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Richienb authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    a95e344 View commit details
    Browse the repository at this point in the history
  39. build: disable v8 pointer compression on 32bit archs

    PR-URL: #40418
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Stewart X Addison <sxa@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    zcbenz authored and targos committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    9f46fca View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2021

  1. tools: udpate doc tools to accommodate GFM footnotes

    PR-URL: #40477
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    507f1db View commit details
    Browse the repository at this point in the history
  2. doc: use GFM footnotes in webcrypto.md

    PR-URL: #40477
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    1587fe6 View commit details
    Browse the repository at this point in the history
  3. deps: upgrade npm to 8.1.1

    PR-URL: #40554
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    npm-robot authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    841f35c View commit details
    Browse the repository at this point in the history
  4. stream: remove no longer necessary ComposeDuplex

    PR-URL: #40545
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    ronag authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    bac7fe0 View commit details
    Browse the repository at this point in the history
  5. meta: update AUTHORS

    PR-URL: #40580
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    nodejs-github-bot authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    488ee51 View commit details
    Browse the repository at this point in the history
  6. doc: improve async_context introduction

    - Rename "Async_context" to "Asynchronous context tracking" in toc.
    - Use named imports to show how `AsyncLocalStorage` and `AsyncResource`
      can be imported.
    
    PR-URL: #40560
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    6e3e50f View commit details
    Browse the repository at this point in the history
  7. doc: fix macOS environment variables for ccache

    macOS requires `cc` and `c++` rather than `gcc` and `g++`.
    
    Closes: #40542
    
    PR-URL: #40550
    Fixes: #40542
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    c1c1738 View commit details
    Browse the repository at this point in the history
  8. doc: simplify ccache instructions

    `ccache` has reasonable defaults for `max_size` and `cache_dir` so
    remove instructions to set those things explicitly.
    
    Change fenced code from `console` to `bash` for easier copy/paste.
    
    PR-URL: #40550
    Fixes: #40542
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    5e2d0ed View commit details
    Browse the repository at this point in the history
  9. meta: consolidate AUTHORS entries for darai0512

    PR-URL: #40569
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    08e7a2f View commit details
    Browse the repository at this point in the history
  10. doc: update onboarding task

    Make starting Jenkins CI optional.
    
    PR-URL: #40570
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    132f6cb View commit details
    Browse the repository at this point in the history
  11. build: skip long-running Actions for README-only modifications

    If the only file modified is README.md do not run test-linux or
    build-windows tasks. This will help streamline onboarding sessions but
    may help some other cases too.
    
    PR-URL: #40571
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    8a00dc5 View commit details
    Browse the repository at this point in the history
  12. module: resolver & spec hardening /w refactoring

    PR-URL: #40510
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    guybedford authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    075cfbf View commit details
    Browse the repository at this point in the history
  13. policy: fix message for invalid manifest specifier

    Add test for invalid manifest specifier and fix the error message
    which is missing a space ("singletrailing" instead of
    "single trailing").
    
    PR-URL: #40574
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    b320387 View commit details
    Browse the repository at this point in the history
  14. http: response should always emit 'close'

    Fixes: #40528
    
    PR-URL: #40543
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ronag authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    825a683 View commit details
    Browse the repository at this point in the history
  15. dgram: fix send with out of bounds offset + length

    fix Socket.prototype.send sending garbage when the message is a string,
    or Buffer and offset+length is out of bounds.
    
    Fixes: #40491
    
    PR-URL: #40568
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Linkgoron authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    79bf429 View commit details
    Browse the repository at this point in the history
  16. doc: fix typo in changelogs

    Fix typo in v12.22.7, v14.18.1, and v16.11.1 changelogs.
    
    PR-URL: #40585
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    lpinca authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    7eb1a44 View commit details
    Browse the repository at this point in the history
  17. meta: consolidate AUTHORS entries for clakech

    PR-URL: #40589
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    ec02e7b View commit details
    Browse the repository at this point in the history
  18. meta: move Fishrock123 to emeritus

    I've moved on. I do not wish to be responsible for anything here and
    have been inactive for more than a year.
    
    PR-URL: #40596
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    Fishrock123 authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    d81b65c View commit details
    Browse the repository at this point in the history
  19. doc: add info on project's usage of coverity

    Document project's used of coverity and how
    collaborators can get access.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #40506
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    mhdawson authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    46ec5ac View commit details
    Browse the repository at this point in the history
  20. tools: fix formatting of warning message in update-authors.js

    The email already has `<` and `>` surrounding it so adding it results in
    a misformatted message.
    
    PR-URL: #40600
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    9cb2116 View commit details
    Browse the repository at this point in the history
  21. tools: update ESLint to 8.1.0

    PR-URL: #40582
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    lpinca authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    7169634 View commit details
    Browse the repository at this point in the history
  22. doc: update CHANGELOG.md for Node.js 16.13.0

    Update missed changes for the main CHANGELOG.md for Node.js 16.13.0.
    
    PR-URL: #40617
    Refs: #40536
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    richardlau authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    0923921 View commit details
    Browse the repository at this point in the history
  23. doc: correct esm spec scope lookup definition

    PR-URL: #40592
    Fixes: #40578
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    guybedford authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    6ae134e View commit details
    Browse the repository at this point in the history
  24. doc: simplify CHANGELOG.md

    Remove unnecessary `<sup>` usage and lint-disabling comment.
    
    PR-URL: #40475
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    5951ccc View commit details
    Browse the repository at this point in the history
  25. doc: remove unused imports

    PR-URL: #40573
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    dnalborczyk authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    4870a23 View commit details
    Browse the repository at this point in the history
  26. doc: call cwd function

    PR-URL: #40573
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    dnalborczyk authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    35dbed2 View commit details
    Browse the repository at this point in the history
  27. doc: add node: url scheme

    PR-URL: #40573
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    dnalborczyk authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    8f41022 View commit details
    Browse the repository at this point in the history
  28. doc: ref OpenSSL legacy provider from crypto docs

    This adds a link to the --openssl-legacy-provider flag to the
    "Support for weak or compromised algorithms" section.
    
    PR-URL: #40593
    Refs: #40478
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    tniessen authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    71bac70 View commit details
    Browse the repository at this point in the history
  29. doc: use 'GitHub Actions workflow' instead

    PR-URL: #40586
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Mesteery authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    c78d708 View commit details
    Browse the repository at this point in the history
  30. typings: improve internal bindings typings

    PR-URL: #40411
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Mesteery authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    90aa96d View commit details
    Browse the repository at this point in the history
  31. meta: consolidate AUTHORS entries for Azard

    PR-URL: #40619
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    88d8127 View commit details
    Browse the repository at this point in the history
  32. meta: consolidate AUTHORS entries for alexzherdev

    PR-URL: #40620
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    18296c3 View commit details
    Browse the repository at this point in the history
  33. test: use conventional argument order in assertion

    PR-URL: #40591
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    cf6ded4 View commit details
    Browse the repository at this point in the history
  34. src: fix #endif description in crypto_keygen.h

    PR-URL: #40639
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    7a22f91 View commit details
    Browse the repository at this point in the history
  35. doc: fix markdown syntax and HTML tag misses

    PR-URL: #40608
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    AliasT authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    65effa1 View commit details
    Browse the repository at this point in the history
  36. doc: update tracking issues of startup performance

    The issues listed in the doc have been closed, and a new one is
    currently being used to track snapshot integration.
    
    PR-URL: #40629
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    ac81f89 View commit details
    Browse the repository at this point in the history
  37. meta: consolidate AUTHORS entries for brettkiefer

    PR-URL: #40599
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    aa98c6b View commit details
    Browse the repository at this point in the history
  38. test: test crypto.setEngine() using an actual engine

    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40481
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RaisinTen authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    179a5c5 View commit details
    Browse the repository at this point in the history
  39. src: remove usage of AllocatedBuffer from node_http2

    Signed-off-by: Darshan Sen <darshan.sen@postman.com>
    
    PR-URL: #40584
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    RaisinTen authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    e9388c8 View commit details
    Browse the repository at this point in the history
  40. tools: avoid fetch extra commits when validating commit messages

    PR-URL: #39128
    Reviewed-By: Mary Marchini <oss@mmarchini.me>
    aduh95 authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    c700de3 View commit details
    Browse the repository at this point in the history
  41. typings: add JSDoc typings for inspector

    Added JSDoc typings for the `inspector` lib module.
    
    PR-URL: #38390
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Adrian Estrada <edsadr@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    VoltrexKeyva authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    da859b5 View commit details
    Browse the repository at this point in the history
  42. doc: remove --experimental-modules documentation

    PR-URL: #38974
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    iam-frankqiu authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    c104f5a View commit details
    Browse the repository at this point in the history
  43. typings: add more bindings typings

    PR-URL: #40415
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Mesteery authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    b4194ff View commit details
    Browse the repository at this point in the history
  44. tools,meta: remove exclusions from AUTHORS

    The update-authors tool omits Chromium team members. This was a decision
    made years ago. The idea was that these folks contributed to V8 not to
    Node.js, as they typically ended up in our code-base via cherry-picked
    commits from V8.
    Ref: #232 (diff)
    
    Now that there are over 3000 contributors identified in AUTHORS, some of
    whom are bots that we run, I think it's time to undo this exception. If
    we used someone else's code in a cherry-pick, congratulations to them,
    they're authors. In particular, this will fix the omission of Yang
    Guo who contributed extensively to Node.js outside of V8 contributions.
    
    PR-URL: #40648
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    16624b4 View commit details
    Browse the repository at this point in the history
  45. doc: final round of markdown format changes

    Once the README and find-inactive-collaborators.mjs changes land here,
    we can introduce markdown formatting as a step in the toolchain
    somewhere.
    
    Before this lands, nodejs/node-core-utils#578
    will need to land and be included in a node-core-utils release.
    
    PR-URL: #40645
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    95a7117 View commit details
    Browse the repository at this point in the history
  46. tools: avoid unnecessary escaping in markdown formatter

    Update mdast-util-to-markdown to 1.2.4 which reduces unnecessary
    escaping of `_` and some other characters. Re-run markdown formatter.
    
    PR-URL: #40645
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    47eddd7 View commit details
    Browse the repository at this point in the history
  47. test: fix test-datetime-change-notify after daylight change

    Add standard timezone name for Dublin without daylight saving
    
    PR-URL: #40684
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    PiotrRybak authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    8fa1c61 View commit details
    Browse the repository at this point in the history
  48. test,tools: increase timeout for benchmark tests

    test-benchmark-buffer is consistently timing out on a single Windows
    host in CI. Rather than try to figure out if we need to scale the
    timeout up for a certain memory limit or chip speed or something else,
    let's increase the timeout for benchmark tests in general.
    
    PR-URL: #40684
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    f731f5f View commit details
    Browse the repository at this point in the history
  49. test,tools: increase pummel/benchmark test timeout from 4x to 6x

    The win10-COMPILED_BY-vs2019 hosts in CI are very slow and timing out on
    certain tests in pummel and (previously) benchmark. Increase timeout
    from 4x to 6x.
    
    PR-URL: #40684
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    1844463 View commit details
    Browse the repository at this point in the history
  50. test: mark test-policy-integrity flaky on Windows

    Ref: #40694
    
    PR-URL: #40684
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    5020f63 View commit details
    Browse the repository at this point in the history
  51. v8: multi-tenant promise hook api

    PR-URL: #39283
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Qard authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    fbeb895 View commit details
    Browse the repository at this point in the history
  52. tools: fix commit-lint workflow

    PR-URL: #40673
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    aduh95 authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    ddc44dd View commit details
    Browse the repository at this point in the history
  53. tools: abort CQ session when landing several commits

    Most PRs are meant to be squashed in one commit when landing. If the
    collaborator hasn't been using `fixup!` commits, the CQ lands the PR
    as several commits. This change makes the CQ abort by default
    when attempting to land several commits, unless there's another
    label added to the PR to force squashing or landing as several commits.
    
    Fixes: #40436
    Refs: nodejs/node-core-utils#572
    
    PR-URL: #40577
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    0787c78 View commit details
    Browse the repository at this point in the history
  54. test,doc: correct documentation for runBenchmark()

    The function only takes two arguments.
    
    PR-URL: #40683
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    126e669 View commit details
    Browse the repository at this point in the history
  55. meta: update AUTHORS

    PR-URL: #40668
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    c2fabdb View commit details
    Browse the repository at this point in the history
  56. doc: format v8.md in preparation for stricter linting

    PR-URL: #40647
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    ecccf48 View commit details
    Browse the repository at this point in the history
  57. tools: notify user if format-md needs to be run

    This will help enforce formatting of markdown files.
    
    PR-URL: #40647
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    5daa313 View commit details
    Browse the repository at this point in the history
  58. doc: fix lint re-enabling comment in README.md

    If there is not a blank line before it, the comment does not re-enable
    the rule.
    
    PR-URL: #40647
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    e374f3d View commit details
    Browse the repository at this point in the history
  59. tools: add script to update c-ares

    Add a script to automate updating of the c-ares dependency and
    accompanying maintenance guide.
    
    PR-URL: #40660
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    richardlau authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    ec2cade View commit details
    Browse the repository at this point in the history
  60. deps: update c-ares to 1.18.1

    Updated as described in doc/guides/maintaining-c-ares.md.
    
    PR-URL: #40660
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    richardlau authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    c003ba1 View commit details
    Browse the repository at this point in the history
  61. deps: upgrade npm to 8.1.2

    PR-URL: #40643
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    npm-robot authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    3805b80 View commit details
    Browse the repository at this point in the history
  62. test: avoid deep comparisons with literals

    Comparing any value to any non-RegExp literal or undefined using
    strictEqual (or notStrictEqual) passes if and only if deepStrictEqual
    (or notDeepStrictEqual, respectively) passes.
    
    Unnecessarily using deep comparisons adds confusion.
    
    This patch adds an ESLint rule that forbids the use of deepStrictEqual
    and notDeepStrictEqual when the expected value (i.e., the second
    argument) is a non-RegExp literal or undefined.
    
    For reference, an ESTree literal is defined as follows.
    
        extend interface Literal <: Expression {
            type: "Literal";
            value: string | boolean | null | number | RegExp | bigint;
        }
    
    The value `undefined` is an `Identifier` with `name: 'undefined'`.
    
    PR-URL: #40634
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    tniessen authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    dfd0215 View commit details
    Browse the repository at this point in the history
  63. doc: update cjs-module-lexer repo link

    PR-URL: #40707
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    guybedford authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    c29658f View commit details
    Browse the repository at this point in the history
  64. esm: add support for JSON import assertion

    Remove V8 flag for import assertions, enabling support for the syntax;
    require the import assertion syntax for imports of JSON.
    
    Support import assertions in user loaders.
    
    Use both resolved module URL and import assertion type as the key for
    caching modules.
    
    Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
    
    PR-URL: #40250
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    aduh95 authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    95e4d29 View commit details
    Browse the repository at this point in the history
  65. tools: fix bug in prefer-primordials ESLint rule

    Refs: #40622
    
    PR-URL: #40628
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    50d102e View commit details
    Browse the repository at this point in the history
  66. test: deflake http2-cancel-while-client-reading

    Add missing `'error'` event handler.
    
    Fixes: #40610
    
    PR-URL: #40659
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lpinca authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    95fe9bb View commit details
    Browse the repository at this point in the history
  67. test: add semicolon after chunk size

    The ABNF for chunk extensions as per RFC 7230 is
    
        chunk-ext      = *( ";" chunk-ext-name [ "=" chunk-ext-val ] )
    
        chunk-ext-name = token
        chunk-ext-val  = token / quoted-string
    
    Add a semicolon after the chunk size for clarity.
    
    This does not invalidate the test as it verifies that the HTTP parser
    does not ignore chunk extensions.
    
    PR-URL: #40487
    Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling
    Reviewed-By: James M Snell <jasnell@gmail.com>
    lpinca authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    ac3bc6e View commit details
    Browse the repository at this point in the history
  68. tools: use GitHub Squash and Merge feature when using CQ

    PR-URL: #40666
    Refs: https://docs.github.com/en/rest/reference/pulls#merge-a-pull-request
    Reviewed-By: Mary Marchini <oss@mmarchini.me>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    aduh95 authored and targos committed Nov 6, 2021
    Configuration menu
    Copy the full SHA
    b7e7368 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. tools: update ESLint to 8.2.0

    PR-URL: #40734
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lpinca authored and targos committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    306d953 View commit details
    Browse the repository at this point in the history
  2. process: refactor execution

    • Removed unreachable code of the `evalModule()` function as an early
    error is thrown when the `print` parameter is a truthy value.
    • Make use of the nullish coalescing operator.
    
    PR-URL: #40664
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    VoltrexKeyva authored and targos committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    ea968d5 View commit details
    Browse the repository at this point in the history
  3. tools: ensure the PR was not pushed before merging

    When using Squash and Merge feature, it would allow to a malicious
    actor to push unreviewed code to their PR while the CQ is running and
    bypass the usual checks.
    This commit adds a check to refuse to land if the head of the PR
    branch is different from the one validated by ncu.
    
    PR-URL: #40747
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    aduh95 authored and targos committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    a3df50d View commit details
    Browse the repository at this point in the history
  4. tools: simplify and fix commit queue

    Use `gh` CLI for CI and commit queue jobs, and use the correct token
    to merge PRs.
    
    PR-URL: #40742
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    targos committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    bbc10f1 View commit details
    Browse the repository at this point in the history
  5. src: make LoadEnvironment with string work with builtin modules path

    Fixes: #40605
    
    PR-URL: #40607
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    targos committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    fb7c437 View commit details
    Browse the repository at this point in the history
  6. test: skip macos sandbox test with builtin modules path

    Refs: #40605
    
    PR-URL: #40607
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    targos committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    8c103ab View commit details
    Browse the repository at this point in the history
  7. test: disable warnings to fix flaky test

    Fixes: #40738
    
    PR-URL: #40739
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 authored and targos committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    e58cce4 View commit details
    Browse the repository at this point in the history
  8. meta: use form schema for flaky test template

    PR-URL: #40737
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    targos committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    d97872d View commit details
    Browse the repository at this point in the history
  9. deps: patch V8 to 9.5.172.25

    Refs: v8/v8@9.5.172.21...9.5.172.25
    
    PR-URL: #40604
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    targos committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    5bef743 View commit details
    Browse the repository at this point in the history
  10. 2021-11-09, Version 17.1.0 (Current)

    Notable changes:
    
    doc:
      * add VoltrexMaster to collaborators (voltrexmaster) #40566
    esm:
      * (SEMVER-MINOR) add support for JSON import assertion (Antoine du Hamel) #40250
    lib:
      * (SEMVER-MINOR) add unsubscribe method to non-active DC channels (simon-id) #40433
      * (SEMVER-MINOR) add return value for DC channel.unsubscribe (simon-id) #40433
    v8:
      * (SEMVER-MINOR) multi-tenant promise hook api (Stephen Belanger) #39283
    
    PR-URL: #40758
    targos committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    2b1744b View commit details
    Browse the repository at this point in the history