Skip to content

tools: use npm ci in Undici update script#63098

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:update-undici
May 5, 2026
Merged

tools: use npm ci in Undici update script#63098
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:update-undici

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented May 3, 2026

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 3, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Renegade334 Renegade334 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 3, 2026
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 3, 2026
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels May 5, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2026
@nodejs-github-bot nodejs-github-bot merged commit 9a076c8 into nodejs:main May 5, 2026
33 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in 9a076c8

@aduh95 aduh95 deleted the update-undici branch May 5, 2026 10:13
aduh95 added a commit that referenced this pull request May 5, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #63098
Refs: nodejs/undici#5139
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants