lib: fix typo in comment in _http_client.js - #64729
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
bjohansebas
approved these changes
Jul 25, 2026
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
agape1225
force-pushed
the
fix-typo-http-client
branch
from
July 25, 2026 05:48
9b8c680 to
0171229
Compare
daeyeon
approved these changes
Jul 25, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64729 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01%
==========================================
Files 743 743
Lines 242407 242407
Branches 45645 45649 +4
==========================================
- Hits 218532 218513 -19
- Misses 15357 15394 +37
+ Partials 8518 8500 -18
🚀 New features to boost your workflow:
|
Collaborator
Collaborator
lpinca
approved these changes
Jul 25, 2026
avivkeller
approved these changes
Jul 25, 2026
avivkeller
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64729 ✔ Done loading data for nodejs/node/pull/64729 ----------------------------------- PR info ------------------------------------ Title lib: fix typo in comment in _http_client.js (#64729) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch agape1225:fix-typo-http-client -> nodejs:main Labels http, author ready Commits 1 - lib: fix typo in comment in _http_client.js Committers 1 - agape1225 <49804691+agape1225@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/64729 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64729 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 25 Jul 2026 05:07:27 GMT ✔ Approvals: 4 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/64729#pullrequestreview-4778522914 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/64729#pullrequestreview-4779125465 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64729#pullrequestreview-4779971821 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/64729#pullrequestreview-4780026972 ✘ GitHub CI failed with status: FAILURE ℹ Last Full PR CI on 2026-07-25T14:19:16Z: https://ci.nodejs.org/job/node-test-pull-request/75127/ - Querying data for job/node-test-pull-request/75127/ ✔ Build data downloaded - Querying failures of job/node-test-commit/89807/ ✔ Data downloaded ✘ 1 failure(s) on the last Jenkins CI run -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/30239696102 |
Contributor
Author
|
It looks like the |
Collaborator
daeyeon
removed
the
commit-queue-failed
Collaborator
daeyeon
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in bf15a4e |
aduh95
pushed a commit
that referenced
this pull request
Aug 3, 2026
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com> PR-URL: #64729 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Aug 4, 2026
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com> PR-URL: #64729 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a typo ("thst" → "that") in a comment in
lib/_http_client.js.