Skip to content

meta: add @nodejs/url as codeowner for node_url_pattern.* - #64737

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
efekrskl:meta/add-glob-to-url-team
Jul 27, 2026
Merged

meta: add @nodejs/url as codeowner for node_url_pattern.*#64737
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
efekrskl:meta/add-glob-to-url-team

Conversation

@efekrskl

@efekrskl efekrskl commented Jul 25, 2026

Copy link
Copy Markdown
Member

As far as I can tell, src/node_url_pattern.* is part of the URL surface, so the team should get pinged on changes

Signed-off-by: Efe Karasakal <hi@efe.dev>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 25, 2026
@Renegade334 Renegade334 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 25, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 27, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 155ac01 into nodejs:main Jul 27, 2026
25 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 155ac01

@pathum25

This comment was marked as spam.

aduh95 pushed a commit that referenced this pull request Aug 3, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64737
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64737
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants