src: handle empty external string resources#64750
Open
Archkon wants to merge 1 commit into
Open
Conversation
V8 requires external string resources to have a non-null data pointer, even when their length is zero. Empty vectors may return a null data pointer, causing NewExternalTwoByte() to abort the process. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
nodejs-github-bot
added
c++
Contributor
Author
|
@joyeecheung @addaleax @kvakil Could you take a look at this? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64750 +/- ##
==========================================
- Coverage 90.15% 90.13% -0.02%
==========================================
Files 743 743
Lines 242413 242420 +7
Branches 45657 45654 -3
==========================================
- Hits 218537 218499 -38
- Misses 15362 15433 +71
+ Partials 8514 8488 -26
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64749