util: preserve function names without source map names - #65108
Open
privatenumber wants to merge 1 commit into
Open
util: preserve function names without source map names#65108privatenumber wants to merge 1 commit into
privatenumber wants to merge 1 commit into
Conversation
Signed-off-by: Hiroki Osame <hiroki.osame@gmail.com>
legendecas
approved these changes
Aug 7, 2026
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65108 +/- ##
==========================================
- Coverage 90.31% 90.31% -0.01%
==========================================
Files 759 759
Lines 248290 248289 -1
Branches 46859 46861 +2
==========================================
- Hits 224241 224232 -9
+ Misses 15472 15468 -4
- Partials 8577 8589 +12
🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
util.getCallSites({ sourceMap: true })replaced a generated function name with an empty string when a valid source map omitted a name segment. Source-map names are optional, so tooling that consumes mapped call sites loses useful stack context.For example, a generated
foo()call mapped by a source map with an emptynamesarray reportedfunctionName: ''instead offunctionName: 'foo'.Changes
Preserve the V8 function name when the source map does not provide a replacement, matching Node.js's source-mapped stack-trace behavior. A regression fixture covers source maps with no name entries.
Fixes: #65104