Skip to content

typings: add fs_event_wrap internal binding types - #65661

Closed
leah-1ee wants to merge 2 commits into
nodejs:mainfrom
leah-1ee:typings-fs-event-wrap
Closed

typings: add fs_event_wrap internal binding types#65661
leah-1ee wants to merge 2 commits into
nodejs:mainfrom
leah-1ee:typings-fs-event-wrap

Conversation

@leah-1ee

Copy link
Copy Markdown
Contributor

Add typings for the fs_event_wrap internal binding.

Changes:

  • Added typings/internalBinding/fs_event_wrap.d.ts
  • Added fs_event_wrap to InternalBindingMap
  • Typed the FSEvent class: start(), close(), hasRef(), ref(),
    unref(), and the onchange callback

Copilot AI lite review requested due to automatic review settings August 30, 2026 07:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nodejs-github-bot nodejs-github-bot added the typings Issues and PRs related to internal TypeScript declarations. label Aug 30, 2026
Add a FsEventWrapBinding declaration for
internalBinding('fs_event_wrap') and wire it into InternalBindingMap.

Signed-off-by: leah-1ee <selee3196@gmail.com>
@leah-1ee
leah-1ee force-pushed the typings-fs-event-wrap branch from a22fb8f to 3238647 Compare August 30, 2026 07:19
Comment thread typings/internalBinding/fs_event_wrap.d.ts Outdated
Signed-off-by: leah-1ee <selee3196@gmail.com>
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 30, 2026
@nodejs-github-bot nodejs-github-bot added lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. labels Sep 1, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

This pull request has multiple commits, but no landing policy was selected.

Add commit-queue-squash PRs the Commit Queue should land as one squashed commit. to land it as one commit, or commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. to land the commits separately.

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
- Loading data for nodejs/node/pull/65661
✔  Done loading data for nodejs/node/pull/65661
----------------------------------- PR info ------------------------------------
Title      typings: add fs_event_wrap internal binding types (#65661)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     leah-1ee:typings-fs-event-wrap -> nodejs:main
Labels     author ready, commit-queue, typings, lacks-second-approval
Commits    2
 - typings: add fs_event_wrap internal binding types
 - typings: fix fs_event_wrap start filename type
Committers 1
 - leah-1ee <selee3196@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65661
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65661
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 30 Aug 2026 07:11:52 GMT
   ✔  Approvals: 1
   ✔  - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65661#pullrequestreview-5060832652
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 65661
From https://github.com/nodejs/node
 * branch                  refs/pull/65661/merge -> FETCH_HEAD
✔  Fetched commits as 5552a068ca6a..8fbf95534daa
--------------------------------------------------------------------------------
Auto-merging typings/globals.d.ts
[main 4217fcde2a] typings: add fs_event_wrap internal binding types
 Author: leah-1ee <selee3196@gmail.com>
 Date: Sun Aug 30 16:10:15 2026 +0900
 2 files changed, 30 insertions(+)
 create mode 100644 typings/internalBinding/fs_event_wrap.d.ts
[main d80fdafd10] typings: fix fs_event_wrap start filename type
 Author: leah-1ee <selee3196@gmail.com>
 Date: Sun Aug 30 21:32:45 2026 +0900
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
(node:583) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
typings: add fs_event_wrap internal binding types

Add a FsEventWrapBinding declaration for
internalBinding('fs_event_wrap') and wire it into InternalBindingMap.

Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65661
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD dd08e34905] typings: add fs_event_wrap internal binding types
 Author: leah-1ee <selee3196@gmail.com>
 Date: Sun Aug 30 16:10:15 2026 +0900
 2 files changed, 30 insertions(+)
 create mode 100644 typings/internalBinding/fs_event_wrap.d.ts
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
typings: fix fs_event_wrap start filename type

Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65661
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD dbd6034c27] typings: fix fs_event_wrap start filename type
 Author: leah-1ee <selee3196@gmail.com>
 Date: Sun Aug 30 21:32:45 2026 +0900
 1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
--------------------------------------------------------------------------------
   ℹ  Add `commit-queue-squash` label to land the PR as one commit, or `commit-queue-rebase` to land as separate commits.

View workflow run

@jasnell jasnell added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 6, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in f16b556...2dfdb6a

nodejs-github-bot pushed a commit that referenced this pull request Sep 6, 2026
Add a FsEventWrapBinding declaration for
internalBinding('fs_event_wrap') and wire it into InternalBindingMap.

Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65661
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Sep 6, 2026
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65661
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 6, 2026
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
Add a FsEventWrapBinding declaration for
internalBinding('fs_event_wrap') and wire it into InternalBindingMap.

Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65661
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65661
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
Add a FsEventWrapBinding declaration for
internalBinding('fs_event_wrap') and wire it into InternalBindingMap.

Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65661
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65661
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants