v8,lib: remove runtime gating of `Float16array` by aduh95 · Pull Request #65702 · nodejs/node

aduh95 · 2026-09-01T09:37:55Z

Runtime flag was removed upstream in v8/v8@f3d4d45, let's land this before Node.js 26 is LTS

nodejs-github-bot · 2026-09-01T09:38:02Z

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/v8-update

nodejs-github-bot · 2026-09-01T13:29:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76823/

codecov · 2026-09-01T13:30:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.96%. Comparing base (6071f8b) to head (4cd3d98).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65702      +/-   ##
==========================================
+ Coverage   89.94%   89.96%   +0.02%     
==========================================
  Files         757      757              
  Lines      258135   258135              
  Branches    48941    48969      +28     
==========================================
+ Hits       232172   232234      +62     
+ Misses      17044    16973      -71     
- Partials     8919     8928       +9

Files with missing lines	Coverage Δ
lib/internal/freeze_intrinsics.js	`97.05% <100.00%> (+0.02%)`	⬆️
lib/internal/per_context/primordials.js	`98.34% <100.00%> (+<0.01%)`	⬆️
lib/internal/util/comparisons.js	`99.71% <100.00%> (-0.01%)`	⬇️
lib/v8.js	`98.79% <100.00%> (-0.01%)`	⬇️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-09-01T21:52:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76859/

nodejs-github-bot · 2026-09-02T10:16:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76880/

nodejs-github-bot · 2026-09-03T09:46:22Z

Commit Queue failed

⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output

- Loading data for nodejs/node/pull/65702
✔  Done loading data for nodejs/node/pull/65702
----------------------------------- PR info ------------------------------------
Title      v8,lib: remove runtime gating of `Float16array` (#65702)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:float16array -> nodejs:main
Labels     lib / src, author ready, needs-ci, commit-queue, commit-queue-rebase, dont-land-on-v22.x, dont-land-on-v24.x
Commits    5
 - deps: V8: backport f3d4d458fe59
 - lib: use `Float16Array` from primordials
 - fixup! lib: use `Float16Array` from primordials
 - fixup! fixup! lib: use `Float16Array` from primordials
 - fixup! lib: use `Float16Array` from primordials
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65702
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65702
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 01 Sep 2026 09:37:55 GMT
   ✔  Approvals: 3
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/65702#pullrequestreview-5077905326
   ✔  - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65702#pullrequestreview-5078767929
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/65702#pullrequestreview-5080014045
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-09-02T10:16:50Z: https://ci.nodejs.org/job/node-test-pull-request/76880/
- Querying data for job/node-test-pull-request/76880/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 65702
From https://github.com/nodejs/node
 * branch                  refs/pull/65702/merge -> FETCH_HEAD
✔  Fetched commits as b53ddc0daabb..f234fbccaec9
--------------------------------------------------------------------------------
[main 3b2d471f04] deps: V8: backport f3d4d458fe59
 Author: Olivier Flückiger <olivf@chromium.org>
 Date: Tue Aug 18 12:45:52 2026 +0000
 12 files changed, 16 insertions(+), 140 deletions(-)
Auto-merging lib/v8.js
[main 42ce82fe68] lib: use `Float16Array` from primordials
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Tue Sep 1 11:34:21 2026 +0200
 3 files changed, 4 insertions(+), 14 deletions(-)
[main ce0651df98] fixup! lib: use `Float16Array` from primordials
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Tue Sep 1 11:50:22 2026 +0200
 1 file changed, 2 insertions(+)
[main ce83170ced] fixup! fixup! lib: use `Float16Array` from primordials
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Tue Sep 1 11:51:01 2026 +0200
 1 file changed, 1 deletion(-)
[main d566c7157b] fixup! lib: use `Float16Array` from primordials
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Tue Sep 1 13:33:09 2026 +0200
 1 file changed, 4 insertions(+)
   ✔  Patches applied
There are 5 commits in the PR. Attempting autorebase.
(node:546) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/7)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
deps: V8: backport f3d4d458fe59

Original commit message:

    [cleanup] Remove --js-float16array

    Remove the --js-float16array flag and incorporate Float16Array into the
    standard typed array macros and baseline snapshot unconditionally.
    Float16Array has been shipping by default since M138.

    Bug: 548385945
    TAG=agy
    CONV=052f499d-4ee5-4a10-8afd-900ba4a338db

    Change-Id: I2c0012158febf422fdc1b866b9414f3f040e83ad
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8264275
    Reviewed-by: Nikolaos Papaspyrou <nikolaos@chromium.org>
    Auto-Submit: Olivier Flückiger <olivf@chromium.org>
    Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#109335}

Refs: https://github.com/v8/v8/commit/f3d4d458fe597b7c949c78f192a87f9d804c9520
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65702
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 4414a01618] deps: V8: backport f3d4d458fe59
 Author: Olivier Flückiger <olivf@chromium.org>
 Date: Tue Aug 18 12:45:52 2026 +0000
 12 files changed, 16 insertions(+), 140 deletions(-)
Rebasing (3/7)
Rebasing (4/7)
Rebasing (5/7)
Rebasing (6/7)
Rebasing (7/7)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
lib: use `Float16Array` from primordials

PR-URL: https://github.com/nodejs/node/pull/65702
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
--------------------------------------------------------------------------------
[detached HEAD 905039dc24] lib: use `Float16Array` from primordials
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Tue Sep 1 11:34:21 2026 +0200
 5 files changed, 9 insertions(+), 14 deletions(-)
Successfully rebased and updated refs/heads/main.
--------------------------------------------------------------------------------
  ✔  4414a0161803ef3f0d065ccaf005d3f4ff61170d
     ✔  0:0      no Assisted-by metadata                   assisted-by-is-trailer
     ✔  0:0      Co-authored-by is a trailer               co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  22:8     PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✔  0:0      skipping sign-off for deps commit         signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ✔  0:0      Title is <= 50 columns.                   title-length
  ✖  905039dc248a76d36d264e1bec205acb16f9e8d8
     ✔  0:0      no Assisted-by metadata                   assisted-by-is-trailer
     ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  1:8      PR-URL is valid.                          pr-url
     ✔  0:0      reviewers are valid                       reviewers
     ✖  0:0      Commit must have a "Signed-off-by" trailer signed-off-by
     ✔  0:0      valid subsystems                          subsystem
     ✔  0:0      Title is formatted correctly.             title-format
     ✔  0:0      Title is <= 50 columns.                   title-length
--------------------------------------------------------------------------------
   ℹ  Please fix the commit message and try again.
Please manually ammend the commit message, by running
`git commit --amend`
Once commit message is fixed, finish the landing command running
`git node land --continue`

View workflow run

Original commit message: [cleanup] Remove --js-float16array Remove the --js-float16array flag and incorporate Float16Array into the standard typed array macros and baseline snapshot unconditionally. Float16Array has been shipping by default since M138. Bug: 548385945 TAG=agy CONV=052f499d-4ee5-4a10-8afd-900ba4a338db Change-Id: I2c0012158febf422fdc1b866b9414f3f040e83ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8264275 Reviewed-by: Nikolaos Papaspyrou <nikolaos@chromium.org> Auto-Submit: Olivier Flückiger <olivf@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#109335} Refs: v8/v8@f3d4d45 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#65702 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

PR-URL: nodejs#65702 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 · 2026-09-03T09:50:47Z

Landed in 6071f8b...4cd3d98

Original commit message: [cleanup] Remove --js-float16array Remove the --js-float16array flag and incorporate Float16Array into the standard typed array macros and baseline snapshot unconditionally. Float16Array has been shipping by default since M138. Bug: 548385945 TAG=agy CONV=052f499d-4ee5-4a10-8afd-900ba4a338db Change-Id: I2c0012158febf422fdc1b866b9414f3f040e83ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8264275 Reviewed-by: Nikolaos Papaspyrou <nikolaos@chromium.org> Auto-Submit: Olivier Flückiger <olivf@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#109335} Refs: v8/v8@f3d4d45 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65702 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

PR-URL: #65702 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 1, 2026

nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 1, 2026

marco-ippolito approved these changes Sep 1, 2026

View reviewed changes

aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Sep 1, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2026

panva approved these changes Sep 1, 2026

View reviewed changes

juanarbol approved these changes Sep 1, 2026

View reviewed changes

panva mentioned this pull request Sep 2, 2026

Only one smartos23-x64 executor online nodejs/build#4387

Open

aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 2, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 3, 2026

o- and others added 2 commits September 3, 2026 11:48

lib: use Float16Array from primordials

4cd3d98

PR-URL: nodejs#65702 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 force-pushed the float16array branch from f234fbc to 4cd3d98 Compare September 3, 2026 09:49

aduh95 merged commit 4cd3d98 into nodejs:main Sep 3, 2026
19 checks passed

aduh95 deleted the float16array branch September 3, 2026 09:50

Navigation Menu

Uh oh!

Uh oh!

v8,lib: remove runtime gating of `Float16array` - #65702

v8,lib: remove runtime gating of `Float16array`#65702
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:float16array

aduh95 commented Sep 1, 2026

Uh oh!

nodejs-github-bot commented Sep 1, 2026

Uh oh!

nodejs-github-bot commented Sep 1, 2026

Uh oh!

codecov Bot commented Sep 1, 2026 •

edited

Loading

Uh oh!

nodejs-github-bot commented Sep 1, 2026

Uh oh!

nodejs-github-bot commented Sep 2, 2026

Uh oh!

nodejs-github-bot commented Sep 3, 2026

Uh oh!

aduh95 commented Sep 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

aduh95 commented Sep 1, 2026

Uh oh!

nodejs-github-bot commented Sep 1, 2026

Uh oh!

nodejs-github-bot commented Sep 1, 2026

Uh oh!

codecov Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Sep 1, 2026

Uh oh!

nodejs-github-bot commented Sep 2, 2026

Uh oh!

nodejs-github-bot commented Sep 3, 2026

Commit Queue failed

Uh oh!

aduh95 commented Sep 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Sep 1, 2026 •

edited

Loading