Making Downloads Trackable (see #1141)#1148
Conversation
All - I updated the long form case studies and the 2016 survey report to make it so I can track on Google Analytics. Let me know if this looks good or what changes I need to make here.
Updated version of PR #1141, adds a global JS helper: Links with the attribute `data-casestudy` will be tracked automatically, using the value of the data attribute as title in Google Analytics.
| s=o.getElementsByTagName(e)[0];j.async=1;j.src='//www.google-analytics.com/analytics.js'; | ||
| s.parentNode.insertBefore(j,s)}(window,document,'ga','script'); | ||
|
|
||
| if (!ga) return; |
There was a problem hiding this comment.
Isn't this redundant? The above IIFE should always add the global ga no?
There was a problem hiding this comment.
If you use an ad-blocker, the GA script will not be loaded and thus the ga object doesn't exist.
| * [Read the full announcement.](/en/blog/announcements/nodejs-foundation-survey/) | ||
| * [See the infographic.](/static/documents/2016-survey-infographic.png) | ||
| * [Read the full report.](/static/documents/2016-survey-report.pdf) | ||
| * <a href="/static/documents/2016-survey-report.pdf" data-casestudy="Node.js 2016 Report">Read the full report.</a> |
There was a problem hiding this comment.
It was treated that way in the original PR. ¯_(ツ)_/¯
|
Just tested this on nodejs.org and doesn't seem to work, at least not in Chrome on my machine. There is no request sent to Google when clicking these links. I assume that is primarily caused by this error:
I'll have a look and open a PR shortly. |
|
This is great, thanks for cleaning this up 👍 |
|
Ops, that |
5 participants
See #1141 for discussion.