Fix JavaScript error related to case study tracking#1155
Merged
Conversation
Member
Author
|
Protip when looking at the diff, add |
lpinca
approved these changes
Feb 22, 2017
Contributor
|
@phillipj Whoops, sorry for that and thanks for fixing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the tracking code just merged to work properly, we need to wrap it into an IIFE because of a
returnstatement which is only valid inside a function. This is what's visible in the console on nodejs.org ATM:That error prevents the case study tracking scripts from attaching its click listeners, resulting in the case study tracking not being invoked at all.
Refs #1148