Fix the anchor link referenced in the Flame Graph docs.#2736
Merged
Trott merged 2 commits intonodejs:masterfrom Nov 5, 2019
Merged
Fix the anchor link referenced in the Flame Graph docs.#2736Trott merged 2 commits intonodejs:masterfrom
Trott merged 2 commits intonodejs:masterfrom
Conversation
… out Node.js internal functions'.
lpinca
approved these changes
Oct 30, 2019
nschonni
reviewed
Oct 30, 2019
|
|
||
| 4. disregard warnings unless they're saying you can't run perf due to missing packages; you may get some warnings about not being able to access kernel module samples which you're not after anyway. | ||
| 5. Run `perf script > perfs.out` to generate the data file you'll visualize in a moment. It's useful to [apply some cleanup](#filtering-out-node-internal-functions) for a more readable graph | ||
| 5. Run `perf script > perfs.out` to generate the data file you'll visualize in a moment. It's useful to [apply some cleanup](#filtering-out-node-js-internal-functions) for a more readable graph |
Member
There was a problem hiding this comment.
Looks like the fix for the built/metalsmith version isn't the same as GitHub (which has it as nodejs with no dash).
Not a big deal since I think it's just broken for both ways right now, but might be an issue if adding https://github.com/remarkjs/remark-validate-links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This initial PR will fix the en version of the docs for issue #2735. Awaiting feedback for desired solutions for other languages.