Skip to content

Fix the anchor link referenced in the Flame Graph docs. #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 2 commits into from
Nov 5, 2019
Merged

Fix the anchor link referenced in the Flame Graph docs. #2736

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0891eb
Fixed the anchor link in the EN docs to correctly point to 'Filtering…
hysan Oct 30, 2019
23027ed
Merge branch 'master' into bugfix/diagnostics-flamegraph-anchor-link
Trott Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion locale/en/docs/guides/diagnostics-flamegraph.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Now let's get to work.
```

4. disregard warnings unless they're saying you can't run perf due to missing packages; you may get some warnings about not being able to access kernel module samples which you're not after anyway.
5. Run `perf script > perfs.out` to generate the data file you'll visualize in a moment. It's useful to [apply some cleanup](#filtering-out-node-internal-functions) for a more readable graph
5. Run `perf script > perfs.out` to generate the data file you'll visualize in a moment. It's useful to [apply some cleanup](#filtering-out-node-js-internal-functions) for a more readable graph
Copy link
Copy Markdown
Member

@nschonni nschonni Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fix for the built/metalsmith version isn't the same as GitHub (which has it as nodejs with no dash).
Not a big deal since I think it's just broken for both ways right now, but might be an issue if adding https://github.com/remarkjs/remark-validate-links

6. install stackvis if not yet installed `npm i -g stackvis`
7. run `stackvis perf < perfs.out > flamegraph.htm`

Expand Down