Skip to content

CI: Orama cloud sync #6806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 4, 2024
Merged

CI: Orama cloud sync #6806

merged 5 commits into from
Jun 4, 2024

Conversation

@canerakdas
Copy link
Member

@canerakdas canerakdas commented Jun 3, 2024 •
edited
Loading

Description

With this PR, we aim to solve the Orama cloud sync issue mentioned in #6719

Related Issues

Related to #6719

@canerakdas canerakdas requested a review from a team as a code owner June 3, 2024 15:32
@vercel
Copy link

vercel bot commented Jun 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 3, 2024 8:45pm

@canerakdas canerakdas added the github_actions:pull-request Trigger Pull Request Checks label Jun 3, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 76 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 98 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.883s ⏱️

@canerakdas canerakdas requested a review from a team as a code owner June 3, 2024 16:17
@canerakdas canerakdas changed the title chore: [WIP/CI] Orama cloud sync, error handling and debug logs CI: Orama cloud sync, error handling and debug logs Jun 3, 2024
@canerakdas canerakdas added the github_actions:pull-request Trigger Pull Request Checks label Jun 3, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 3, 2024
@canerakdas canerakdas changed the title CI: Orama cloud sync, error handling and debug logs CI: [WIP] Orama cloud sync, error handling and debug logs Jun 3, 2024
@ovflowd
Copy link
Member

ovflowd commented Jun 3, 2024

Is it still a WIP?

@ovflowd
Copy link
Member

ovflowd commented Jun 3, 2024

@canerakdas can you make the changes to the GitHub Action Workflow on a separate PR so I can merge it first?

@canerakdas

This comment was marked as off-topic.

Sign in to view
@ovflowd
Copy link
Member

ovflowd commented Jun 3, 2024

Is it still a WIP?

The last build failed, so I marked it as WIP. I'm trying to understand the problem 🤔

@canerakdas can you make the changes to the GitHub Action Workflow on a separate PR so I can merge it first?

Sure, I will open it as a separate PR after solving this problem 👍

After solving what problem? You know changes to the workflow only take effect after merging.

So Imo the workflow change should fix this, but we can only test that after you merge the workflow changes 😅

@canerakdas
Copy link
Member Author

canerakdas commented Jun 3, 2024

After solving what problem? You know changes to the workflow only take effect after merging.

So Imo the workflow change should fix this, but we can only test that after you merge the workflow changes 😅

Updated 😄 I'd better get some rest, I'm starting to see non-existent issues 👻

@canerakdas canerakdas added the github_actions:pull-request Trigger Pull Request Checks label Jun 3, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 3, 2024
@canerakdas canerakdas changed the title CI: [WIP] Orama cloud sync, error handling and debug logs CI: Orama cloud sync Jun 3, 2024
@ovflowd
Copy link
Member

ovflowd commented Jun 4, 2024

Fast-tracking this to see if it fixes the upload!

@ovflowd ovflowd added this pull request to the merge queue Jun 4, 2024
Merged via the queue into nodejs:main with commit e67490d Jun 4, 2024
This was referenced Jun 4, 2024
Merged
Merged
@canerakdas canerakdas mentioned this pull request Jun 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovflowd ovflowd ovflowd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@canerakdas @ovflowd