Skip to content

Conversation

@canerakdas
Copy link
Member

Description

To check the developments in this pull request and ensure that it works successfully, error handling/logging has been added in the necessary areas to ensure that the build has the correct status in case of any issues during the build process

Validation

We should see the Orama Cloud sync completed successfully! in the build logs

Related Issues

Related to #6719

@canerakdas canerakdas requested a review from a team as a code owner June 4, 2024 13:47
@vercel
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 4, 2024 1:48pm

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jun 4, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 97 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 96 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.977s ⏱️

@AugustinMauroy
Copy link
Member

Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeesto mikeesto added this pull request to the merge queue Jun 6, 2024
Merged via the queue into nodejs:main with commit 18abb2a Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants