Orama / search refinement #8381
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8381 +/- ##
==========================================
- Coverage 76.40% 76.35% -0.05%
==========================================
Files 118 118
Lines 9928 9905 -23
Branches 334 334
==========================================
- Hits 7585 7563 -22
+ Misses 2341 2340 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
| {suggestions.map((suggestion, i) => ( | ||
| <Suggestions.Item {...props} key={i} className={styles.suggestionItem}> | ||
| <SparklesIcon /> | ||
| <Suggestions.Item |
There was a problem hiding this comment.
I put a breakpoint within https://github.com/oramasearch/orama-ui/blob/main/packages/ui/src/components/Suggestions.tsx#L53-L59 - and I can see the stream return from the useChat ask call.
There was a problem hiding this comment.
copilot thinks it might have to do with context order or nesting... that could make sense as we moved things around across package boundaries. I will keep plugging away
There was a problem hiding this comment.
All of these references are now dead 🤷
📦 Build Size ComparisonSummary
Changes➕ Added Assets (5)
➖ Removed Assets (5)
|
Description
Validation
Related Issues
Started work against #8376
According to the report, #8352 introduced the regressions.
#8380 Seems to have no bearing on the behavior.
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.