-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Orama / search refinement #8381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,8 +18,12 @@ const SearchSuggestions: FC<SearchSuggestionsProps> = ({ | |
| <Suggestions.Wrapper className={styles.suggestionsWrapper}> | ||
| {label && <p className={styles.suggestionsTitle}>{label}</p>} | ||
| {suggestions.map((suggestion, i) => ( | ||
| <Suggestions.Item {...props} key={i} className={styles.suggestionItem}> | ||
| <SparklesIcon /> | ||
| <Suggestions.Item | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I put a breakpoint within https://github.com/oramasearch/orama-ui/blob/main/packages/ui/src/components/Suggestions.tsx#L53-L59 - and I can see the stream return from the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. copilot thinks it might have to do with context order or nesting... that could make sense as we moved things around across package boundaries. I will keep plugging away |
||
| {...props} | ||
| key={`suggestion-${i}`} | ||
| className={styles.suggestionItem} | ||
| > | ||
| <SparklesIcon key={`suggestion-icon-${i}`} /> | ||
| {suggestion} | ||
| </Suggestions.Item> | ||
| ))} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these references are now dead 🤷