-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: semantic version in release blog posts #8520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/releasers Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8520 +/- ##
==========================================
- Coverage 74.70% 74.66% -0.05%
==========================================
Files 102 102
Lines 8956 8956
Branches 305 306 +1
==========================================
- Hits 6691 6687 -4
- Misses 2263 2267 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
avivkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we leave the previous blog posts the same, and only start applying this to future posts?
|
I'll update @node-core/remark-lint with this new requirement, as well |
Why? We did update old posts in #7998, I don't think it broke anything |
|
That change was a bit different, IMO. This is referring to the actual version, and I think it's important to maintain consistency, however, I'm not going to force it, if you think this is best, go ahead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
I think there's a misunderstanding, the actual version does not change, e.g. v0.10.0 has always been Node.js 0.10.0, before or after this change. This PR is simply updating the blog posts to match our style guide, it is not a renaming nor a new requirement (very similar to #7998). |
|
Has the tooling that generates these posts been updated? |
Yes, as you can see in the diff (https://github.com/nodejs/nodejs.org/pull/8520/files#diff-873e2ee117570f0836a600113925cbeb0929ece48acb9df0076d06b54f17d0e4) |
Description
SImilar to #7998, our guidelines indicates we should be using Node.js x.y.z instead of Node.js vx.y.z.
Refs: https://github.com/nodejs/node/blob/668e52339261ec21c7388884620987914c833395/doc/README.md#L220-L222
Fixes: nodejs/node#61231
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.