Skip to content

docs(ui): add stories for Privacy page#2319

Open
cylewaitforit wants to merge 1 commit intonpmx-dev:mainfrom
cylewaitforit:sb-privacy-page
Open

docs(ui): add stories for Privacy page#2319
cylewaitforit wants to merge 1 commit intonpmx-dev:mainfrom
cylewaitforit:sb-privacy-page

Conversation

@cylewaitforit
Copy link
Copy Markdown
Contributor

@cylewaitforit cylewaitforit commented Mar 29, 2026

🔗 Linked issue

#2150

🧭 Context

This would also enable a storybook mock page, storybook a11y checks, and chromatic visual regression tests for this page as documented by the storybook stories.

📚 Description

Adds stories for Privacy page.

Creates shared pagesDecorator to reduce duplication in stories.

https://698b88d5157d89f1f33a6c21-hffnzxcven.chromatic.com/?path=/story/pages-privacy--default

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 29, 2026 11:25pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 29, 2026 11:25pm
npmx-lunaria Ignored Ignored Mar 29, 2026 11:25pm

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2026

📝 Walkthrough

Walkthrough

This pull request introduces a centralized Storybook decorator (pageDecorator) in .storybook/decorators.ts that wraps stories with AppHeader, AppFooter, and a consistent full-height page layout with focus management. Multiple page story files (about.stories.ts, accessibility.stories.ts) have been refactored to use this shared decorator instead of inline decorator logic. A new story file for the privacy page has been added using the same decorator. Module resolution aliases (#storybook/*) have been configured in both nuxt.config.ts and package.json to support imports from the .storybook directory.

Possibly related PRs

Suggested reviewers

  • ghostdevv
  • JReinhold
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset. It explicitly mentions adding stories for the Privacy page and creating a shared pageDecorator, which directly corresponds to the file changes shown in the raw summary.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant