Skip to content

Add Laravel 13 support#2762

Draft
nielseulink wants to merge 2 commits intonuwave:masterfrom
nielseulink:feat/laravel-13-support
Draft

Add Laravel 13 support#2762
nielseulink wants to merge 2 commits intonuwave:masterfrom
nielseulink:feat/laravel-13-support

Conversation

@nielseulink
Copy link

Summary

  • Widen illuminate/* version constraints from ^9 || ^10 || ^11 || ^12 to ^9 || ^10 || ^11 || ^12 || ^13
  • Widen laravel/framework (require-dev) to include ^13
  • Update orchestra/testbench to include ^11 for Laravel 13 test compatibility

Laravel 13 was released and this change allows Lighthouse to be installed alongside it. The illuminate/* components in Laravel 13 follow the same patterns as previous versions, so no code changes should be needed.

Made with Cursor

Widen illuminate/* and laravel/framework version constraints to include ^13, and update orchestra/testbench to ^11 for Laravel 13 compatibility.

Made-with: Cursor
@Luke-Shepp
Copy link
Contributor

@nielseulink Was just about to do similar - thanks!

I presume they'll want .github/workflows/validate.yml updating too to run tests against L13.

@nielseulink
Copy link
Author

@Luke-Shepp Yeah, good one!

Copy link
Collaborator

@spawnia spawnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove explanatory comments?

- name: lowest
arg: "--prefer-lowest --prefer-stable"
- name: highest
arg: "" # No args added as highest is default
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comment should stay.

@spawnia spawnia marked this pull request as draft March 22, 2026 10:30
@spawnia
Copy link
Collaborator

spawnia commented Mar 22, 2026

Looks like nothing works yet.

@stayallive
Copy link
Collaborator

bensampo/laravel-enum is going to be blocking. What should we do about that? It looks like it won't be updated for Laravel 13 so we either drop it here (which would require a major release) or we do need to do a release for L13 at bensampo/laravel-enum anyway.

@eshimischi
Copy link

eshimischi commented Mar 23, 2026

@stayallive Alternatives like archtechx/enums don't work ?

@Luke-Shepp
Copy link
Contributor

Luke-Shepp commented Mar 23, 2026

It's looking like a new major version dropping PHP 8.0 support and the BenSampo enum package is the only way to go -- in favour of native enums.

There doesn't seem to be any chance of the package getting updated, see BenSampo/laravel-enum#366, so dropping support really is the only option.

Anyone on Laravel 13 will be dropping BenSampo/laravel-enum themselves as part of the upgrade, so nuwave/lighthouse not supporting it is no issue.

@eshimischi
Copy link

@Luke-Shepp good point, let's go with it.

@spawnia
Copy link
Collaborator

spawnia commented Mar 23, 2026

As far as Lighthouse is concerned, the support for BenSampo/laravel-enum is only an adapter. We should remove the package from require-dev when installing Laravel 13, then skip tests and static analysis for it. That way, we don't have to wait and don't have to break existing users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants