Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

chore: bump nuxt version#299

Closed
aldarund wants to merge 4 commits into
masterfrom
aldarund-patch-1
Closed

chore: bump nuxt version#299
aldarund wants to merge 4 commits into
masterfrom
aldarund-patch-1

Conversation

@aldarund

@aldarund aldarund commented Jul 26, 2019

Copy link
Copy Markdown
Collaborator

No description provided.

clarkdo
clarkdo reviewed Jul 26, 2019
View reviewed changes

@clarkdo clarkdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^2.0.0 covers all 2.x version, so I think we don't need to change it before 3.0

@aldarund

aldarund commented Jul 26, 2019

Copy link
Copy Markdown
Collaborator Author

@clarkdo its so that new users dont ask why i used CNA and i have in package.json 2.0.0 instead of latest one

@clarkdo

clarkdo commented Jul 26, 2019

Copy link
Copy Markdown
Member

I prefer sending them to semver site. 😅

aldarund added 2 commits July 26, 2019 16:11
@aldarund
Merge remote-tracking branch 'remotes/origin/master' into aldarund-pa…
40506d6 
…tch-1

# Conflicts:
#	test/snapshots/index.test.js.md
#	test/snapshots/index.test.js.snap
@aldarund
update test snapshots
b34a86f
@aldarund

aldarund commented Jul 26, 2019

Copy link
Copy Markdown
Collaborator Author

thats a point, but there another questions that they ask so its just to minimize it.
Whatever, do as you feel better, its not important issue to discuss it much :)

@TheAlexLichter

TheAlexLichter commented Jul 26, 2019

Copy link
Copy Markdown
Member

Agree with @clarkdo here. Better educate the user about NPM constraints and semver instead (maybe directly write a FAQ in the README?)

@aldarund

aldarund commented Jul 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

I`m afraid users who ask such questions dont read readme :)

@TheAlexLichter

TheAlexLichter commented Jul 26, 2019

Copy link
Copy Markdown
Member

Could be 🤷‍♂️ but that should not be part of our scope.

@pi0

pi0 commented Sep 30, 2019

Copy link
Copy Markdown
Member

Some suggestion: We may show a message after setup you created a project using latest nuxt x.y.z

@clarkdo

clarkdo commented Sep 30, 2019

Copy link
Copy Markdown
Member

I’ll add the message

@TheAlexLichter
TheAlexLichter deleted the aldarund-patch-1 branch October 8, 2019 18:18
@TheAlexLichter TheAlexLichter mentioned this pull request Oct 8, 2019
Open
@vinayakkulkarni vinayakkulkarni mentioned this pull request Jan 5, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@clarkdo clarkdo clarkdo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aldarund @clarkdo @TheAlexLichter @pi0