Skip to content

fix(devtools): drop stale visibility assertion from nuxt-group e2e test #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 1 commit into from
Jul 24, 2026
+9 −5
Merged

fix(devtools): drop stale visibility assertion from nuxt-group e2e test #1042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions tests/e2e/specs/nuxt-group.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,21 @@ test('registers a single `Nuxt` group with `nuxt:devtools` as its default child'
expect(memberIds).toContain('nuxt:devtools:settings')
expect(memberIds.length).toBeGreaterThan(1)

// The anchor's own dock button is redundant next to those members, so it's
// registered with a render-only `visibility: 'false'` (devframe#136): its
// button is suppressed while the entry stays registered — keeping its
// `subTabs`/`frameId` shared iframe alive and driving the nav loop.
// The anchor's own dock button would ideally be suppressed via a
// render-only `visibility: 'false'` (devframe#136) since it's redundant
// next to those members, but that's currently disabled in `module-main.ts`
// — the group button's `defaultChildId` fallback looks the entry up
// through the same visibility filter, so hiding the anchor also breaks
// clicking into it from the `Nuxt` group button. Once that's fixed
// upstream, re-enable `visibility: 'false'` there and restore this
// assertion. Until then, the entry stays registered and visible, keeping
// its `subTabs`/`frameId` shared iframe alive and driving the nav loop.
const anchor = await page.evaluate(() => {
const ctx = (globalThis as any).__VITE_DEVTOOLS_CLIENT_CONTEXT__
return ctx.docks.entries.find((entry: any) => entry.id === 'nuxt:devtools')
})
expect(anchor).toMatchObject({
id: 'nuxt:devtools',
visibility: 'false',
subTabs: { protocol: 'postmessage' },
})
})
Loading