deps: migrate markdown-it to markdown-exit - #1057
Conversation
Replace the direct markdown-it dependency with markdown-exit, a drop-in TypeScript rewrite of markdown-it with compatible plugin API. Add a pnpm override so unplugin-vue-markdown's own transitive markdown-exit dependency converges on the same version instead of shipping a second copy of the engine.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR replaces Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Replaces the direct
markdown-itdependency inpackages/devtoolswithmarkdown-exit, a drop-in TypeScript rewrite of markdown-it with compatible plugin API and its own types.packages/devtools/client/composables/client-services/markdown.tsnow lazily importscreateMarkdownExitfrommarkdown-exitinstead of the default-exportedMarkdownItconstructor.@types/markdown-it(no longer needed —markdown-exitships its own types).markdown-itVite chunk key inpackages/devtools/client/nuxt.config.tstomarkdown-exit.markdown-exitto the version this workspace depends on directly, sounplugin-vue-markdown's own transitivemarkdown-exitdependency converges on the same version instead of the lockfile shipping two copies of the engine.markdown-it-link-attributesand the.md→ Vue SFC compilation pipeline (unplugin-vue-markdown+@mdit-vue/*, which still depend on realmarkdown-itfor frontmatter/component parsing) are unaffected — this only swaps the engine used for rendering runtime markdown strings (e.g. RPC docs/tooltips) in the devtools client.Verification
pnpm typecheckpnpm lintpnpm test:unitpnpm -C packages/devtools exec nuxi generate client(confirms the.mddocs pipeline and the renamedvendor/markdown-exitchunk both build cleanly)This PR was created with the help of an agent.