Skip to content

Conversation

@Intevel
Copy link
Contributor

@Intevel Intevel commented Oct 19, 2022

No description provided.

@codesandbox
Copy link

codesandbox bot commented Oct 19, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@Baroshem
Copy link
Contributor

Thanks for doing that! I really appreciate it! 💚

Let's merge it when it will be approved 😉

@atinux atinux requested review from danielroe and pi0 October 19, 2022 20:04
@danielroe
Copy link
Member

@Baroshem
Copy link
Contributor

@danielroe I will implement them in the next version of the module (0.4.0).

Do you think that they are blockers for this PR to be merged?

@pi0
Copy link
Member

pi0 commented Oct 21, 2022

Hi @Intevel. Thanks for the nice efforts on security module 💯 I've made a quick review Baroshem/nuxt-security#30 once solved i think we can list module 👍🏼

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked issues to be solved in next release

@pi0 pi0 merged commit 415e0ce into nuxt:main Oct 21, 2022
@Baroshem
Copy link
Contributor

Thanks guys!

I expect to release a new version tomorrow with all the recomendations :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants