Fail with error if user attempts to uninstall NVDA while it is running

[nvaccessAuto]

Reported by elliott94 on 2012-12-22 23:40
Currently, if eSpeak is set as the default synth during an uninstall, it stops producing output after the process has started, i.e. the Uninstall button is pressed. However, a dialog is presented at the end of the uninstall which prompts the user as to whether they want to reboot now or later. However, this prompt doesn't get any feedback. This doesn't occur if another synth is selected.

[nvaccessAuto]

Comment 1 by elliott94 on 2012-12-22 23:40
Changes:
Changed title from "Allow a synthesizer to be used for the entirety of uninstallation" to "Allow eSpeak to be used for the entirety of uninstallation"

[nvaccessAuto]

Comment 2 by mdcurran on 2012-12-23 04:48
I fear that other features of NVDA would not work while on that final dialog. The reason espeak stops is because many of its files have already been deleted, though it seems eSpeak is not caching or locking those files.
I'm more likely to accept that we simply throw up an error at the start, or kill NVDA off, if its running when trying to uninstall.

[nvaccessAuto]

Comment 3 by jteh on 2012-12-26 03:09
NVDA can't be expected to run during uninstallation, since it's being uninstalled. I'd probably vote for presenting an error, as users might still expect it to work somehow. Note that we can't present the error from NSIS due to localisation issues, so it'll probably have to be slave.

[bhavyashah]

@jcsteh Could you please modify the ticket title accordingly to reflect our mostly agreed decision that a warning/error should be presented to mitigate any potential confusion as noted in yours and Mick's comments?

[Adriani90]

@elliott94 can you still reproduce this with NVDA 2018.4 Beta 1?

[jcsteh]

Even if the original issue can't be reproduced (and I suspect it can), the idea here is still valid; i.e. fail with an error if the user attempts to uninstall while NVDA is running.See #2890 (comment) and #2890 (comment).

[LeonarddeR]

It should be not too difficult to do this, see https://nsis.sourceforge.io/Check_whether_your_application_is_running
I'd go for the mutex approach. SInce NSIS isn't very hard to dive into and the reference is pretty neat, marking this as good for new dev.

[Adriani90]

cc: @seanbudd

[seanbudd]

@Adriani90 could you please explain the tag?

[Adriani90]

Ah sorry, I just thought you might want to give it a priority. It still affects users, especially when the dialog after uninstall is not spoken at all.