Vocalize MS Word change tracking activation and deactivation.#10212
Merged
michaelDCurran merged 3 commits intoSep 16, 2019
Conversation
Collaborator
|
Any possibility of getting this included in any potential 2019.2.1? It has come
up on the user list as well.
…--
Luke Davis
Moderator: the new NVDA Help mailing list! (https://groups.io/g/NVDAHelp)
Author: Debug Helper NVDA add-on (https://addons.nvda-project.org/addons/debugHelper.en.html)
|
|
PR introduces Flake8 errors 😲 See test results for Failed build of commit 2e07e2e6dd |
Contributor
Author
|
@XLTechie: |
michaelDCurran
approved these changes
Sep 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #942
Summary of the issue:
In MS Word, the toggle shortcut control+shift+E to enable or disable change tracking is not vocalized.
Description of how this pull request fixes the issue:
This PR allows to have the change tracking state announced when the change tracking gesture is executed.
This PR does not include the possibly required changes in each local gestures.ini files to match the word localized shortcut to toggle change tracking activation. This need to be done by translators.
Testing performed:
Test on French MS Word where change tracking toggle shortcut is Ctrl+Shift+R insstead of Ctrl+Shift+E.
Checked that the shortcut is correctly vocalized at step 3 and 5 and that the word "the" is marked as inserted at step 7.
Known issues with pull request:
None
Change log entry:
Changes
The shortcut to toggle change tracking state now announce the new change tracking state in Microsoft Word . (#942)