Skip to content

Vocalize MS Word change tracking activation and deactivation.#10212

Merged
michaelDCurran merged 3 commits into
nvaccess:masterfrom
CyrilleB79:vocalizeChangeTracking
Sep 16, 2019
Merged

Vocalize MS Word change tracking activation and deactivation.#10212
michaelDCurran merged 3 commits into
nvaccess:masterfrom
CyrilleB79:vocalizeChangeTracking

Conversation

@CyrilleB79
Copy link
Copy Markdown
Contributor

Link to issue number:

fixes #942

Summary of the issue:

In MS Word, the toggle shortcut control+shift+E to enable or disable change tracking is not vocalized.

Description of how this pull request fixes the issue:

This PR allows to have the change tracking state announced when the change tracking gesture is executed.
This PR does not include the possibly required changes in each local gestures.ini files to match the word localized shortcut to toggle change tracking activation. This need to be done by translators.

Testing performed:

Test on French MS Word where change tracking toggle shortcut is Ctrl+Shift+R insstead of Ctrl+Shift+E.

  1. Modify fr local gestures.ini file as follow:
@@ -9,7 +9,8 @@
        toggleRightMouseButton = kb(laptop):nvda+control+*

 [NVDAObjects.window.winword.WordDocument]
-       None = kb:control+b, kb:control+[, kb:control+], "kb:control+shift+,", kb:control+shift+., kb:control+l, kb:cont
rol+r
+       None = kb:control+b, kb:control+[, kb:control+], "kb:control+shift+,", kb:control+shift+., kb:control+l, kb:cont
rol+r, kb:control+shift+e^M
        increaseDecreaseFontSize = kb:control+shift+<, kb:control+shift+>, kb:control+alt+<, kb:control+alt+>
        toggleBold = kb:control+g, kb:control+shift+b
        toggleAlignment = kb:control+shift+g, kb:control+shift+d
+       toggleChangeTracking = kb:control+shift+r^M
  1. Open a new document in word and start typing "Hello "
  2. Press Ctrl+Shift+R
  3. Type "the "
  4. Press Ctrl+Shift+R
  5. Type "world !"
  6. Go back with left arrow to see what is marked as inserted.

Checked that the shortcut is correctly vocalized at step 3 and 5 and that the word "the" is marked as inserted at step 7.

Known issues with pull request:

None

Change log entry:

Changes
The shortcut to toggle change tracking state now announce the new change tracking state in Microsoft Word . (#942)

@XLTechie
Copy link
Copy Markdown
Collaborator

XLTechie commented Sep 14, 2019 via email

@AppVeyorBot
Copy link
Copy Markdown

PR introduces Flake8 errors 😲

See test results for Failed build of commit 2e07e2e6dd

@CyrilleB79
Copy link
Copy Markdown
Contributor Author

@XLTechie:
I do not believe a 2019.2.1 will be released. And if even it was, it would include only critical fixes, not a new feature PR like this one.

@michaelDCurran michaelDCurran merged commit a507d52 into nvaccess:master Sep 16, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Sep 16, 2019
michaelDCurran added a commit that referenced this pull request Sep 16, 2019
@CyrilleB79 CyrilleB79 deleted the vocalizeChangeTracking branch July 6, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVDA Should Announce Tracked Changes in Microsoft Office Word

5 participants