IA2 vbuf: IAccessible2::attribute_src: Truncate base64 data yet preserve the MIME type#10290
Merged
Merged
Conversation
…rve the MIME type
michaelDCurran
approved these changes
Sep 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow up of #10231
Summary of the issue:
When the
srcattribute of animgelements contains huge base64 data, the virtual buffer is uselessly filled with potentially lengthy content that impact performance.Description of how this pull request fixes the issue:
When the value of the
srcstarts with "data:", locate "base64," and truncate everything onward, replacing it with "<truncated>".Testing performed:
Tested against the test case of #10227.
Known issues with pull request:
Change log entry:
I'm not sure this deserves to be announced.
Otherwise:
Section: Changes for developers
Firefox and Chrome: In the
srcattribute of animgelement, base64 data are now truncated from the virtual buffer.