Fix bullet reading in Word#10404
Merged
michaelDCurran merged 2 commits intonvaccess:masterfrom Oct 21, 2019
Merged
Conversation
|
PR introduces Flake8 errors 😲 See test results for Failed build of commit 79e41d948a |
michaelDCurran
approved these changes
Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10399
Summary of the issue:
Some bullets characters are not announced correctly ("black club" instead of "black square" and "double right arrow" instead of "right arrow"). Moreover, PUA mapping is not correct for u+F0D8 and u+F0E8 (checked visually and with matching tables found on http://www.alanwood.net).
Description of how this pull request fixes the issue:
Remapped the following bullet characters in the mapPUAToUnicode dictionary:
And modified symbols.dic files consequently.
Note: all the lines of mapPUAToUnicode dictionary show a change in the diff since I have added the name of each character in the end line comment. However, only the 3 mapping value have been modified.
Testing performed:
Checked in the document PRBullets.docx that bullets are correctly announced.
Known issues with pull request:
None
Change log entry:
Bug fixes
Some bullet names in Microsoft Word have been corrected. (#10399)