Remove base implementation of synthDriverHandler.SynthDriver.speak#10431
Merged
michaelDCurran merged 1 commit intonvaccess:masterfrom Oct 28, 2019
BabbageCom:synthDriverHandlerFix
Merged
Remove base implementation of synthDriverHandler.SynthDriver.speak#10431michaelDCurran merged 1 commit intonvaccess:masterfrom BabbageCom:synthDriverHandlerFix
michaelDCurran merged 1 commit intonvaccess:masterfrom
BabbageCom:synthDriverHandlerFix
Conversation
LeonarddeR
changed the title
michaelDCurran
approved these changes
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
During speech refactor, the speakText and speakCharacter methods were removed from synthesizer drivers. However, the base implementation wasn't updated accordingly.
Description of how this pull request fixes the issue:
The speak method is now abstract and raises NotImplementedError by default.
Testing performed:
Tested instantiating
synthDriverHandler.SynthDriver. Noticed that the speak method was marked as abstract.Known issues with pull request:
None
Change log entry:
None needed