Flake8: ignore source/comInterfaces directory#10929
Merged
feerrenrut merged 1 commit intonvaccess:masterfrom Apr 2, 2020
Merged
Flake8: ignore source/comInterfaces directory#10929feerrenrut merged 1 commit intonvaccess:masterfrom
feerrenrut merged 1 commit intonvaccess:masterfrom
Conversation
Ignore files located in source/comInterfaces directory when linting, as files in there come from third-party generated modules. This affects UI Automation COM interface as new interfaces are added.
Contributor
|
I won't add an entry to the change log for this since it's pretty minor, but thank you for providing one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10924
Summary of the issue:
When COM interfaces modified by third-party modules are added/changed and scons lint is run, Flake8 issues hundreds of errors.
Description of how this pull request fixes the issue:
As third-party modules live in source/comInterfaces folder, ignore the contents of the folder altogether.
Testing performed:
Source code copy of NVDA, with scons lint run before nad after this change to make sure no errors are encountered.
Known issues with pull request:
None
Change log entry:
Possibly changes for developers:
NVDA will no longer issue linting errors when third-party generated interface modules are added or changed. (#10922
Thanks.