Watchdog: List stacks for all Python threads when trying to recover from freeze#11417
Merged
michaelDCurran merged 1 commit intomasterfrom Jul 26, 2020
Merged
Watchdog: List stacks for all Python threads when trying to recover from freeze#11417michaelDCurran merged 1 commit intomasterfrom
michaelDCurran merged 1 commit intomasterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
feerrenrut
approved these changes
Jul 24, 2020
LeonarddeR
approved these changes
Jul 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
NVDA's watchdog tries to recover from freezes, and when doing so logs the main thread's stack. However, the freeze may be caused also by what is going on in another thread. We should log stacks for all Python threads when trying to recover.
Description of how this pull request fixes the issue:
Log stacks for all Python threads when watchdog is trying to recover from a possible freeze.
Note that we already started logging all threads when the core was completely frozen. This pr extends this to recovery attempts also.
Testing performed:
Caused NVDA to temporarily freeze and try recovery by opening the Python console, typing
time.sleep(5), pressing enter and alt tabbing away quickly.Confirmed that the the log showed the message about trying to recover from freeze, and that it listed all Python threads.
Known issues with pull request:
None.
Change log entry:
None.