Don't use sibling text as the description of groupings in IA2 web browsers. #11448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Blocks #11120.
Summary of the issue:
NVDA uses the sibling text of a grouping in Firefox or Chrome as the description for the grouping. While this is appropriate for Win32 group boxes, it is inappropriate for IA2 web browsers. Specifically, in Firefox with NODE_CHILD_OF removed (see #11120), it causes "grouping </" to be reported whenever you enter a nested tree item in the Dev Tools main inspector.
The reason this doesn't occur with NODE_CHILD_OF is that Firefox skips grouping ancestors with NODE_CHILD_OF.
Description of how this pull request fixes the issue:
In ia2Web.findExtraOverlayClasses, Groupbox is removed if present.
Testing performed:
Test case:
data:text/html,<button>before</button><fieldset><input></fieldset>After<br>Tabbed to the input.
Before PR: "grouping after, edit has autocomplete"
After PR: just "edit has autocomplete"
Known issues with pull request:
None.
Change log entry:
I doubt anyone has seen this in the wild, and given how obscure this is, I'm not sure it's worth having a What's New entry for it. The reason for this PR is #11120, but the problem wouldn't be noticeable until that PR is merged.