Skip to content

Prevent running Windows 10 OCR if screen curtain is enabled. #11921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelDCurran merged 3 commits into from
Jan 20, 2021
Merged

Prevent running Windows 10 OCR if screen curtain is enabled. #11921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
505c9d6
Prevent running Windows 10 OCR if screen curtain is enabled.
CyrilleB79 Dec 7, 2020
8bc6e85
Merge branch 'master' into ocrWarning
michaelDCurran Jan 20, 2021
2d34fb7
Update what's new
michaelDCurran Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions source/globalCommands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3109,6 +3109,14 @@ def script_recognizeWithUwpOcr(self, gesture):
# Translators: Reported when Windows 10 OCR is not available.
ui.message(_("Windows 10 OCR not available"))
return
from visionEnhancementProviders.screenCurtain import ScreenCurtainProvider
screenCurtainId = ScreenCurtainProvider.getSettings().getId()
screenCurtainProviderInfo = vision.handler.getProviderInfo(screenCurtainId)
isScreenCurtainRunning = bool(vision.handler.getProviderInstance(screenCurtainProviderInfo))
if isScreenCurtainRunning:
# Translators: Reported when screen curtain is enabled.
ui.message(_("Please disable screen curtain before using Windows 10 OCR."))
return
from contentRecog import uwpOcr, recogUi
recog = uwpOcr.UwpOcr()
recogUi.recognizeNavigatorObject(recog)
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ What's New in NVDA

== Changes ==
- In browse mode, controls can now be activated with braille cursor routing on their descriptor (ie. "lnk" for a link). This is especially useful for activating eg. check-boxes with no labels. (#7447)
- NVDA now prevents the user from performing Windows 10 OCR if screen curtain is enabled. (#11911)


== Bug Fixes ==
Expand Down
4 changes: 4 additions & 0 deletions user_docs/en/userGuide.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,6 +794,8 @@ For this situation, NVDA contains a feature called "screen curtain" which can be

You can enable the Screen Curtain in the [vision category #VisionSettings] of the [NVDA Settings #NVDASettings] dialog.

When the screen curtain is active some tasks directly based on what appears on the screen such as performing [OCR #Win10Ocr] or taking a screenshot cannot be achieved.

+ Content Recognition +[ContentRecognition]
When authors don't provide sufficient information for a screen reader user to determine the content of something, various tools can be used to attempt to recognize the content from an image.
NVDA supports the optical character recognition (OCR) functionality built into Windows 10 to recognize text from images.
Expand All @@ -815,6 +817,8 @@ NVDA can use this to recognize text from images or inaccessible applications.
You can set the language to use for text recognition in the [Windows 10 OCR category #Win10OcrSettings] of the [NVDA Settings #NVDASettings] dialog.
Additional languages can be installed by opening the Start menu, choosing Settings, selecting Time & Language -> Region & Language and then choosing Add a language.

Windows 10 OCR may be partially or fully incompatible with [NVDA vision enhancements #Vision] or other external visual aids. You will need to disable these aids before proceeding to a recognition.

%kc:beginInclude
To recognize the text in the current navigator object using Windows 10 OCR, press NVDA+r.
%kc:endInclude
Expand Down