Fix isCurrent errors for Internet Explorer#12066
Merged
feerrenrut merged 3 commits intomasterfrom Feb 23, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
lukaszgo1
previously approved these changes
Feb 12, 2021
Contributor
lukaszgo1
left a comment
lukaszgo1
left a comment
There was a problem hiding this comment.
Many thanks for this PR!
Contributor
Author
|
There is still some underlying issue. When an exception is thrown here there is some kind of cyclic reference created. I haven't tracked down the cause of it yet. This PR can be merged, but there will need to be a follow up to find the true cause of the issue. |
michaelDCurran
requested changes
Feb 14, 2021
Co-authored-by: Michael Curran <michaelDCurran@users.noreply.github.com>
michaelDCurran
approved these changes
Feb 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12055
Summary of the issue:
Errors raised after unhandled value of 'None' for aria-current
Description of how this pull request fixes the issue:
Handles None value, mapping to isCurrent.No
Testing strategy:
Manually tested with http://test-cases.tink.uk/aria-current/
In browse mode and focus mode
This code would be hard to unit test.
We don't have system tests for internet explorer yet.
Known issues with pull request:
None
Change log entry:
None - bug not included in a release
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Please do a self-review to check these items.
Reviewers will not approve the PR until these are met.