Conversation
See test results for failed build of commit a8fa24f386 |
michaelDCurran
approved these changes
Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
closes #12151
Summary of the issue:
The settings dialog
NVDA Menu/Preferences/Input Gesturesdoes not open. This is because an alignment flag that was previously ignored now throws an error in the latest wxWidgets.Traceback:
Description of how this pull request fixes the issue:
Removes the alignment flag.
Testing strategy:
Open the
Input Gesturessettings dialog and ensure the layout and functionality is the same.Ensure that the flags
wx.ALIGN_LEFT,wx.ALIGH_RIGHT,wx.ALIGN_CENTER_HORIZONTAL, are only used inwx.VERTICALoriented sizersEnsure that the flag
wx.ALIGN_CENTER_VERTICALis only used inwx.HORIZONTALoriented sizersKnown issues with pull request:
None
Change log entry:
None (fixes regression with unreleased python3.8/wxWidgets alpha upgrade)
Code Review Checklist: