Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinVersion class follow-up: remove ease of access is supported flag #12222

Merged
merged 10 commits into from
Apr 21, 2021

Conversation

josephsl
Copy link
Collaborator

Link to issue number:

Follow-up to PR #11909

Summary of the issue:

NVDA requires Windows 7/Server 2008 R2 SP1 or later, therefore Ease of Access is available.

Description of how this pull request fixes the issue:

Removes easeOfAccess.isSupported flag.

Testing strategy:

Code review (Grep used), manual testing to make sure easeOfAccess.isSupported raises AttributeError.

Known issues with pull request:

None

Change log entry:

Changes for developers:

easeOfAccess.isSupported has been removed.

Code Review Checklist:

This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x: [ ] becomes [x].
You can also check the checkboxes after the PR is created.

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

Thanks.

… conditionals.

As NVDA requires Windows 7/Server 2008 R2 SP1, Ease of Access support can be used directly. Therefore remove this flag from various config functions.
…Access flag.

Remove Ease of Access flag from start on logon screens function.
As NVDA requires Windows 7/Server 2008 R2 SP1 or later, Eae of Access can be used, therefore remove this flag. Also add type hints for desktop config switch flag.
@seanbudd seanbudd added the deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release label Apr 20, 2021
@seanbudd seanbudd added this to the 2021.1 milestone Apr 20, 2021
@seanbudd seanbudd self-assigned this Apr 20, 2021
Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephsl. Looks good to me, can also confirm there are no other usages after merging in master (e019a24).

source/config/__init__.py Outdated Show resolved Hide resolved
@josephsl
Copy link
Collaborator Author

josephsl commented Apr 20, 2021 via email

@josephsl josephsl requested a review from a team as a code owner April 21, 2021 03:21
@josephsl
Copy link
Collaborator Author

Hi,

Review comments addressed.

Thanks.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephsl , LGTM

@seanbudd seanbudd merged commit 6200a07 into nvaccess:master Apr 21, 2021
@seanbudd seanbudd mentioned this pull request Apr 23, 2021
18 tasks
@josephsl josephsl deleted the removeEaseOfAccessIsSupportedFlag branch May 7, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated/2021.1 Label used to track deprecations due for removal in the 2021.1 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants