WinVersion class follow-up: remove ease of access is supported flag#12222
Merged
seanbudd merged 10 commits intonvaccess:masterfrom Apr 21, 2021
Merged
WinVersion class follow-up: remove ease of access is supported flag#12222seanbudd merged 10 commits intonvaccess:masterfrom
seanbudd merged 10 commits intonvaccess:masterfrom
Conversation
… conditionals. As NVDA requires Windows 7/Server 2008 R2 SP1, Ease of Access support can be used directly. Therefore remove this flag from various config functions.
…Access flag. Remove Ease of Access flag from start on logon screens function.
As NVDA requires Windows 7/Server 2008 R2 SP1 or later, Eae of Access can be used, therefore remove this flag. Also add type hints for desktop config switch flag.
seanbudd
added
the
deprecated/2021.1
Contributor
Author
|
Hi, I see. I’ll address this as early as upcoming weekend. Thanks.
|
Contributor
Author
|
Hi, Review comments addressed. Thanks. |
…sl/nvda into removeEaseOfAccessIsSupportedFlag
seanbudd
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow-up to PR #11909
Summary of the issue:
NVDA requires Windows 7/Server 2008 R2 SP1 or later, therefore Ease of Access is available.
Description of how this pull request fixes the issue:
Removes easeOfAccess.isSupported flag.
Testing strategy:
Code review (Grep used), manual testing to make sure easeOfAccess.isSupported raises AttributeError.
Known issues with pull request:
None
Change log entry:
Changes for developers:
easeOfAccess.isSupported has been removed.
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x:
[ ]becomes[x].You can also check the checkboxes after the PR is created.
Thanks.