Rename Windows 10 OCR to Windows OCR#12691
Merged
seanbudd merged 7 commits intonvaccess:betafrom Jul 29, 2021
Merged
Conversation
…e to cover future Windows releases. Re nvaccess#12690
josephsl
requested review from
Qchristensen and
seanbudd
and removed request for
a team
See test results for failed build of commit 4103053fb4 |
CyrilleB79
reviewed
Jul 27, 2021
|
|
||
| ++ Windows 10 OCR ++[Win10Ocr] | ||
| ++ Windows OCR ++[Win10Ocr] | ||
| Windows 10 includes OCR for many languages. |
Contributor
There was a problem hiding this comment.
This one was missing:
Suggested change
| Windows 10 includes OCR for many languages. | |
| Windows 10 and beyond includes OCR for many languages. |
Contributor
Author
|
Hi, that one will be covered in #12683. Thanks.
|
Contributor
OK, thanks. |
seanbudd
previously approved these changes
Jul 28, 2021
seanbudd
approved these changes
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #12690
Summary of the issue:
Windows OCR feature is "limited" to Windows 10 when in fact it can be used in Windows 11 and later as well.
Description of how this pull request fixes the issue:
Rename Windows 10 OCR to Windows OCR.
Testing strategy:
Manual testing, building NVDA from source and chekcing generated user guide files.
Known issues with pull request:
Translations will not work, which is expected as strings were changed as part of this PR. Also, in user guide, anchors were not modified.
Change log entries:
Changes:
Windows 10 OCR was renamed to Windows OCR. (#12690)
Code Review Checklist: